From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BE2E17622E for ; Tue, 25 Jun 2024 17:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719335015; cv=none; b=Q5UjAg4csRaBDxzcglFS+Q5K3e67jBVj2BHPSJvxJ4VkL/mPwiQwa1jPE9C59p5zkRacVM0ks9/I205tMl7h3QijCstBLBzi8XCl9SsRgBPvC4C7jgj+2f0kbOCMwf1Cf+P2UFH6A2qJzBt7yxCW5ljvlEwwp5kMfOJbP8EOYGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719335015; c=relaxed/simple; bh=SVzx7dPM+zj5mTLpINrOuLlod98o5OR3JttDI7Y5g54=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=TgSg04L7pNG5wgcP7RZilhUxTVsD/EKfXEjkxyVQRiGV5ET4uP+YZqPeu/CIEBMBtgbOaZsSQO9whibYJuJ39GuKNkuRywdaNot8jVKIdHd3y8w7FzUfuZbaOjssEfkk9RcNXj5G1VLozLPjFjprts2c7KurMXB4BvDUzp5jcR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tbclVZzy; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tbclVZzy" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a6fe118805dso360064266b.3 for ; Tue, 25 Jun 2024 10:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719335011; x=1719939811; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=w5ecAzurX6IYGeYDcIsPTa6P3ILX2WujtqR+TA0/x2M=; b=tbclVZzybAhiWDO+vdp7re6fsEXi36+ybmnX373XpxmV1/cKqN+7GE5tSi1YVn0faF N+JdfAQRyk9r9pXA7713X0JIZ4KWpNGEdQYMM5QwkNBy/qPz+HJ5cGqDmmxbwTpHd7dw 7yrMgkjlS4eBhF0wOecFY3pVf9jfdjXNzh5sN9QCcRShK8aGkaFYv/1WnBjCDA29Zmyp BtoSqjuAE6In4Zf8zXk865b2xhR99UnQ+U9sMI9N7nU1WN0GIK789A+vRWKMbniAFbWs 33QTLYx8OamokrrA10vd14mGcOI755mFYrQbVzAlRZJxc5wwZa9+URR9F60W3RRffOVY g9hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719335011; x=1719939811; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w5ecAzurX6IYGeYDcIsPTa6P3ILX2WujtqR+TA0/x2M=; b=MuBkodDHE+2C0n/8p+MP3PeBePgTmJgQH5GquCeQJtVy7vwe7itUo6vN3mHss6rH/h iRj0iqu0wSh7UGUKjNOWyiubUum2zTh426R/PgSiQxf2logdto5sfhS5DBMee1YS0sf6 o7p8R7lhYOYsibMtpl9Mj8xHibItYzfL0poJQwL8QzHqLuol+/ccpxq8Q8GHzcL586ny lU/rbLlLBENFu3vzM7WiFJjsIdUVniL4cnQhJF1GlO6dl7FekT0+5gJlB74M6mLS+WJA REnlqB5NSYL6S+mqBNoAFdFk/db4RJLaEHjbviH71SMMwImVklGS5R1ZFw5mj03EsFa+ 3xHQ== X-Forwarded-Encrypted: i=1; AJvYcCUrlWgDP0cvevPjZCunOtIrmJ5PZHrdgBR+5zU2uPEN0bS2HhyTvHn8hAPL7wRrFF2yjAGE5dV8MjhXPrD7baO+unzDNaSXmBkcMA== X-Gm-Message-State: AOJu0YwEApFcm1PgtuSJM2cZMVjJOvlOfBhz+XqOdt1jGcc4K06mBdSI Lbh1wXgDrJBlYztkI1dFfeMRg9YSxM4Pxyaul4Kg9DwtPCZOTFjDuD895LFoi4I= X-Google-Smtp-Source: AGHT+IHscyf9+UEi9wBBgYaC+ZxpUPrgpqEIcOMWpZVc2SrnmDeMBWYSMnQj4yV2fzoiGTx6eVxpSA== X-Received: by 2002:a17:906:d001:b0:a72:44c1:a2e8 with SMTP id a640c23a62f3a-a7245cf2d6dmr423429066b.45.1719335011327; Tue, 25 Jun 2024 10:03:31 -0700 (PDT) Received: from [192.168.215.29] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a725047c407sm263798166b.2.2024.06.25.10.03.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 10:03:30 -0700 (PDT) Message-ID: <2391a1a1-46d3-4ced-a31f-c80194fdaf29@linaro.org> Date: Tue, 25 Jun 2024 19:03:27 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V4 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574 To: Devi Priya , andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, richardcochran@gmail.com, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, neil.armstrong@linaro.org, arnd@arndb.de, m.szyprowski@samsung.com, nfraprado@collabora.com, u-kumar1@ti.com, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org References: <20240625070536.3043630-1-quic_devipriy@quicinc.com> <20240625070536.3043630-6-quic_devipriy@quicinc.com> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20240625070536.3043630-6-quic_devipriy@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25.06.2024 9:05 AM, Devi Priya wrote: > Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based > devices. > > Signed-off-by: Devi Priya > Tested-by: Alexandru Gagniuc > --- [...] > + struct regmap *regmap; > + struct qcom_cc_desc nsscc_ipq9574_desc = nss_cc_ipq9574_desc; Why? > + struct clk *nsscc_clk; > + struct device_node *np = (&pdev->dev)->of_node; > + int ret; > + > + nsscc_clk = of_clk_get(np, 11); > + if (IS_ERR(nsscc_clk)) > + return PTR_ERR(nsscc_clk); > + > + ret = clk_prepare_enable(nsscc_clk); pm_clk_add()? And definitely drop the 11 literal, nobody could ever guess or maintain magic numbers Konrad