From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jernej Skrabec Subject: Re: [PATCH v7 0/8] drm: sun8i: Add DE2 HDMI video support Date: Tue, 29 Nov 2016 15:24:25 -0800 (PST) Message-ID: <239b60f3-3ea7-4aa7-8e8d-353e1a1d4ee5@googlegroups.com> References: <20161129213650.uqcgekodq77wlmxs@lukather> <8398357e-5c5e-4d76-9022-1c668aff5076@googlegroups.com> <2256264.6LWGGhFAiO@avalon> Reply-To: jernej.skrabec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_6744_1714802487.1480461865753" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <2256264.6LWGGhFAiO@avalon> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: linux-sunxi Cc: jernej.skrabec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, moinejf-GANU6spQydw@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, kieran.bingham-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org List-Id: devicetree@vger.kernel.org ------=_Part_6744_1714802487.1480461865753 Content-Type: multipart/alternative; boundary="----=_Part_6745_530421893.1480461865754" ------=_Part_6745_530421893.1480461865754 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Laurent, Dne torek, 29. november 2016 23.56.31 UTC+1 je oseba Laurent Pinchart=20 napisala: > > Hi Jernej,=20 > > (CC'ing Kieran Bingham)=20 > > On Tuesday 29 Nov 2016 14:47:20 Jernej Skrabec wrote:=20 > > Dne torek, 29. november 2016 22.37.03 UTC+1 je oseba Maxime Ripard=20 > napisala:=20 > > > On Tue, Nov 29, 2016 at 11:18:35AM +0100, Jean-Francois Moine wrote:= =20 > > >> This patchset series adds HDMI video support to the Allwinner=20 > > >> sun8i SoCs which include the display engine 2 (DE2).=20 > > >> The driver contains the code for the A83T and H3 SoCs, and=20 > > >> some H3 boards, but it could be used/extended for other SoCs=20 > > >> (A64, H2, H5) and boards (Banana PIs, Orange PIs).=20 > > >=20 > > > Honestly, I'm getting a bit worried by the fact that you ignore=20 > > > reviews.=20 > > >=20 > > > On the important reviews that you got that are to be seen as major=20 > > >=20 > > > issues that block the inclusion, we have:=20 > > > - The fact that the HDMI driver is actually just a designware IP,= =20 > > > and while you should use the driver that already exists, you just= =20 > > > duplicated all that code.=20 > >=20 > > That might be hard thing to do. A83T fits perfectly, but H3 and newer= =20 > SoCs=20 > > do not. They are using completely different HDMI phy. Decoupling=20 > controller=20 > > and phy code means rewritting a good portion of the code, unless some= =20 > tricks=20 > > are applied, like calling phy function pointers, if they are defined.= =20 > > Same HDMI TX but different HDMI TX PHY ? Kieran is working on decoupling= =20 > the=20 > PHY configuration code for a Renesas SoC, that might be of interest to=20 > you.=20 > Exactly. I'm developing only U-Boot driver, but Jean-Francois will probably have more interest in this. =20 > > > Register addresses also differ, but that can be easily solved by using= =20 > > undocumented magic value to restore them.=20 > > I love that :-)=20 > > Is it allowed to use magic number which was found in binary blob? I'm new i= n all this. =20 > > > - The fact that you ignored Rob (v6) and I (v5) comment on using OF= =20 > > > graph to model the connection between the display engine and the= =20 > > > TCON. Something that Laurent also pointed out in this version.=20 > > > =20 > > > - The fact that you ignored that you needed an HDMI connector node= =20 > > > as a child of the HDMI controller. This has been reported by Rob= =20 > > > (v6) and yet again in this version by Laurent.=20 > > > =20 > > > - And finally the fact that we can't have several display engine in= =20 > > > parallel, if needs be. This has happened in the past already on= =20 > > > Allwinner SoCs, so it's definitely something we should consider i= n=20 > > > the DT bindings, since we can't break them.=20 > > >=20 > > > Until those are fixed, I cannot see how this driver can be merged,=20 > > > unfortunately.=20 > > --=20 > Regards,=20 > > Laurent Pinchart=20 > > Best regards, Jernej =C5=A0krabec=20 --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. ------=_Part_6745_530421893.1480461865754 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Laurent,

Dne torek, 29. november 2016 23.56.31 U= TC+1 je oseba Laurent Pinchart napisala:
Hi Jernej,

(CC'ing Kieran Bingham)

On Tuesday 29 Nov 2016 14:47:20 Jernej Skrabec wrote:
> Dne torek, 29. november 2016 22.37.03 UTC+1 je oseba Maxime Ripard= napisala:
> > On Tue, Nov 29, 2016 at 11:18:35AM +0100, Jean-Francois Moine= wrote:
> >> This patchset series adds HDMI video support to the Allwi= nner
> >> sun8i SoCs which include the display engine 2 (DE2).
> >> The driver contains the code for the A83T and H3 SoCs, an= d
> >> some H3 boards, but it could be used/extended for other S= oCs
> >> (A64, H2, H5) and boards (Banana PIs, Orange PIs).
> >=20
> > Honestly, I'm getting a bit worried by the fact that you = ignore
> > reviews.
> >=20
> > On the important reviews that you got that are to be seen as = major
> >=20
> > issues that block the inclusion, we have:
> > =C2=A0 - The fact that the HDMI driver is actually just a des= ignware IP,
> > =C2=A0 =C2=A0 and while you should use the driver that alread= y exists, you just
> > =C2=A0 =C2=A0 duplicated all that code.
>=20
> That might be hard thing to do. A83T fits perfectly, but H3 and ne= wer SoCs
> do not. They are using completely different HDMI phy. Decoupling c= ontroller
> and phy code means rewritting a good portion of the code, unless s= ome tricks
> are applied, like calling phy function pointers, if they are defin= ed.

Same HDMI TX but different HDMI TX PHY ? Kieran is working on decouplin= g the=20
PHY configuration code for a Renesas SoC, that might be of interest to = you.

Exactly. I'm developing only U-Boot driver, b= ut Jean-Francois will probably
have more interest in this.
=C2=A0

> Register addresses also differ, but that can be easily solved by u= sing
> undocumented magic value to restore them.

I love that :-)


Is it allowed to use magic number which was found= in binary blob? I'm new in
all this.
=C2=A0
> > =C2=A0 - The fact that you ignored = Rob (v6) and I (v5) comment on using OF
> > =C2=A0 =C2=A0 graph to model the connection between the displ= ay engine and the
> > =C2=A0 =C2=A0 TCON. Something that Laurent also pointed out i= n this version.
> > =C2=A0=20
> > =C2=A0 - The fact that you ignored that you needed an HDMI co= nnector node
> > =C2=A0 =C2=A0 as a child of the HDMI controller. This has bee= n reported by Rob
> > =C2=A0 =C2=A0 (v6) and yet again in this version by Laurent.
> > =C2=A0=20
> > =C2=A0 - And finally the fact that we can't have several = display engine in
> > =C2=A0 =C2=A0 parallel, if needs be. This has happened in the= past already on
> > =C2=A0 =C2=A0 Allwinner SoCs, so it's definitely somethin= g we should consider in
> > =C2=A0 =C2=A0 the DT bindings, since we can't break them.
> >=20
> > Until those are fixed, I cannot see how this driver can be me= rged,
> > unfortunately.

--=20
Regards,

Laurent Pinchart


Best regards,
Jernej =C5=A0krabec

--
You received this message because you are subscribed to the Google Groups &= quot;linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-s= unxi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org.
For more options, visit http= s://groups.google.com/d/optout.
------=_Part_6745_530421893.1480461865754-- ------=_Part_6744_1714802487.1480461865753--