From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B400EC76196 for ; Mon, 3 Apr 2023 18:33:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233262AbjDCSdv (ORCPT ); Mon, 3 Apr 2023 14:33:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233260AbjDCSdf (ORCPT ); Mon, 3 Apr 2023 14:33:35 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CE603581 for ; Mon, 3 Apr 2023 11:32:59 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id w9so121070346edc.3 for ; Mon, 03 Apr 2023 11:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680546778; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EPWT5mMmuGrFkQaGaj75abt7BvFmjgz0kWUiVZiK+60=; b=F2GsOoTdBB99ORU2xWrBAyXtTxEW63x/qTkd9bnEjUalG0IkTiwxfDqA6EYadBh8pP vwyMm+hX6ih0XzUM4XtCwk4+vZUdjXdYE6bJHph8vK6cQO6iDgBm3PUIaisbCAOOkA86 l9WaVyERMvWNz1GmqPxdgqdIF4tfvEkw62UeH0Iwv8od2RImp00TZREbGnqrbtlqXpxe IhAOAcTAXtQR3WvPXGOClOo90KVfGODQjFXF7uN003AI2qKMYiRYtgoR9a9ckkyVPEfn nO8LUwxUVeBT36nvPtpcRJ9C3SHnHGlkFMul6ogJoooxMiABfRUaLaEUnfj4QF9fp8d3 L48Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680546778; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EPWT5mMmuGrFkQaGaj75abt7BvFmjgz0kWUiVZiK+60=; b=J0l2KZWcJGfLo1Vh/J21o0OJDOazLjOZ119X0V9/0EU/NBlLRkPhA77U4OuAkbE7B5 0Oil9cIpanFCcOEwOggwRhrraB1imK2xsJ5IT19RzQo1QH9Au1s7McaMZ6ujaPqo0mMi BPdXn76obNIdpkR9KaEYu+1JUuvRp4khAcEVM0MowBFhRCesXRsleVDfZRD5U/bpvpxF lQXSSY8MSOfio06+bwEEBp7/L/qGj/u0PvRjdww7CTuJk9tIjoxaSybmawnYkAvx5728 P+OD5Q3/5YPU9xjxGWqqK1Y0T7vgkqfgcOpLjVDkEtqLpYJ4A4t3RjtT/YRVSbMFfV3K 3Skw== X-Gm-Message-State: AAQBX9dOnRcShQvy+ZUJZ4ACW8kincnN5Jpwtm/lHtpMdaKrHtOAw6zo 1oqNPiH+4SmMVCs8sx0DW7W2+TBnAmagLyTt4Nk= X-Google-Smtp-Source: AKy350aW2SN3jstLLNu7d+H5mzsNCZIqfayZUeK8PGvt9ZdUMKzysVtsFyu0PycM5P2N+wDccL5QXA== X-Received: by 2002:aa7:c699:0:b0:4fb:80cf:89e6 with SMTP id n25-20020aa7c699000000b004fb80cf89e6mr172550edq.8.1680546777852; Mon, 03 Apr 2023 11:32:57 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ae90:d80:1069:4805? ([2a02:810d:15c0:828:ae90:d80:1069:4805]) by smtp.gmail.com with ESMTPSA id p9-20020a50cd89000000b004c0c5864cc5sm4915461edi.25.2023.04.03.11.32.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 11:32:57 -0700 (PDT) Message-ID: <23a7215e-0be4-195c-f3c9-3b1d1b760fa0@linaro.org> Date: Mon, 3 Apr 2023 20:32:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V3 2/4] dt-bindings: watchdog: xlnx,versal-wwdt: Add versal watchdog bindings Content-Language: en-US To: Srinivas Neeli , shubhrajyoti.datta@amd.com, michal.simek@amd.com, srinivas.goud@amd.com, wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@amd.com, git@xilinx.com, neelisrinivas18@gmail.com References: <20230331074117.356339-1-srinivas.neeli@amd.com> <20230331074117.356339-3-srinivas.neeli@amd.com> From: Krzysztof Kozlowski In-Reply-To: <20230331074117.356339-3-srinivas.neeli@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/03/2023 09:41, Srinivas Neeli wrote: > Versal watchdog driver uses window watchdog mode. Window watchdog Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > timer(WWDT) contains closed(first) and open(second) window with > 32 bit width. Write to the watchdog timer within predefined window > periods of time. This means a period that is not too soon and > a period that is not too late. > > This patch adds devicetree bindings for versal window watchdog device. Do not use "This commit/patch", but imperative mood. See: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Signed-off-by: Srinivas Neeli > --- > Changes in V3: > - Removed xlnx,close_percent property. > Changes in V2: > - Added watchdog ref > - Removed timeout-sec property > - Used 4 spaces for example indentation. > --- > .../bindings/watchdog/xlnx,versal-wwdt.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > new file mode 100644 > index 000000000000..dea1e7c487d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/xlnx,versal-wwdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx Versal window watchdog timer controller > + > +maintainers: > + - Neeli Srinivas > + > +description: > + Versal watchdog driver uses window watchdog mode. Window watchdog What is driver? If you mean Linux driver, then drop all references to it and rephrase to describe hardware. > + timer(WWDT) contains closed(first) and open(second) window with > + 32 bit width. Write to the watchdog timer within predefined window > + periods of time. This means a period that is not too soon and a > + period that is not too late. The WWDT has to be restarted within > + the open window time. If software tries to restart WWDT outside of > + the open window time period, it generates a reset. > + > +allOf: > + - $ref: /schemas/watchdog/watchdog.yaml# All other examples reference local watchdog.yaml. Don't do it differently than others (git grep watchdog.yaml) > + Best regards, Krzysztof