From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E5C6C677F1 for ; Mon, 16 Jan 2023 15:54:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231421AbjAPPy4 (ORCPT ); Mon, 16 Jan 2023 10:54:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231506AbjAPPyo (ORCPT ); Mon, 16 Jan 2023 10:54:44 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A6F7222DC for ; Mon, 16 Jan 2023 07:54:43 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id d30so38399241lfv.8 for ; Mon, 16 Jan 2023 07:54:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/J5BwwFc+cz/TVDnLga/TBpZtC0SR+xIrcvCr3tsklE=; b=mjEe8zC+F2uzPnl/V19BJ86H1CRNDA0hltY9Vvgnodci10MGhKWGVcfnVjG3kMJWq2 C6EL8sZ5hOTQsKERCDp+oGg6RRkDkRUOcIg7e7fSwuidSM0XgyhEvG8lXWSoffnZSJYE tBvtE+U6BaD+q8NWWp6OuaqJMf9pN68BYeYepcxtDncxZojcgBJ1ClBKj6ppmrYGdEPS lOOkujclXuQWaQn7wHUNr6sBaR7OJEJx7CuJMgu2edIMVEOGbFMpORghxSA1CLP8F8RD tZa0DHcVYN5xa/Vovk9M7X6YYD82A7D6aUGHrTD/Idbb9ohDkIA9xNOHE9XHUe5QzkF2 bE/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/J5BwwFc+cz/TVDnLga/TBpZtC0SR+xIrcvCr3tsklE=; b=wSF3DSivmgbtrknedRtoJynmLCwnJW4VF5thKIb5oh8K72UXVAYdgaJ83whSml1r04 iFO/34n3b4h8GRu58sYSD8J9HcXSutr0ibCALk/cYqrTU7my7Oe+zgWhEKSFHlaNfek9 +lRWW95Gn4mF4ppQTY5vp2dMBqlu3PG5b3E36YM34ESj0Bac7Vtm0d355OrViToHT19L PSXce2MYQcHHzqHEaJM6R4K2TwpbpSVx02iSCP2kKFcdzlDLaS5kzSiPhlToI4psTq6t Kj8LzU/1GH1uYg3kdMJodxIqUaJEqFFaPoInHJT0NsHKQK4WDapI1etGegqyCuqiM4oO r0Vg== X-Gm-Message-State: AFqh2krOZjGSJsA/eZBUuuBOqJbiGLPiQjU8wXnROl2cXtj0Iyh9mvom EM97C4+GhToNiE59xsYm91mQyA== X-Google-Smtp-Source: AMrXdXsBv/GWU6qRrChpha6bgiHRPoveqk+ry3Qo/ejYePhKMUqXzP3fbH+paG3qpb92rYWDro/jlg== X-Received: by 2002:ac2:5fad:0:b0:4b5:964d:499e with SMTP id s13-20020ac25fad000000b004b5964d499emr24222483lfe.8.1673884481873; Mon, 16 Jan 2023 07:54:41 -0800 (PST) Received: from [192.168.1.101] (abym53.neoplus.adsl.tpnet.pl. [83.9.32.53]) by smtp.gmail.com with ESMTPSA id d23-20020a056512369700b004cc86bc8f22sm3604692lfs.90.2023.01.16.07.54.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 07:54:41 -0800 (PST) Message-ID: <23b4551c-db79-d859-c037-6ed3c8a11883@linaro.org> Date: Mon, 16 Jan 2023 16:54:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] dt-bindings: qcom: geni-se: Fix '#address-cells' & '#size-cells' related dt-binding error Content-Language: en-US To: Bhupesh Sharma , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, agross@kernel.org, andersson@kernel.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20230113201038.267449-1-bhupesh.sharma@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16.01.2023 16:43, Bhupesh Sharma wrote: > On Mon, 16 Jan 2023 at 13:23, Krzysztof Kozlowski > wrote: >> >> On 15/01/2023 22:33, Bhupesh Sharma wrote: >>> On Sun, 15 Jan 2023 at 20:57, Krzysztof Kozlowski >>> wrote: >>>> >>>> On 13/01/2023 21:10, Bhupesh Sharma wrote: >>>>> Fix the following '#address-cells' & '#size-cells' related >>>>> dt-binding error: >>>>> >>>>> $ make dtbs_check >>>>> >>>>> From schema: Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml >>>>> arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dtb: geniqup@4ac0000: >>>>> #address-cells:0:0: 2 was expected >>>>> From schema: Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml >>>> >>>> Don't we want rather to unify the soc address range? >>> >>> Well, the assumption in the original dt-bindings was that every reg >>> variable is 4 * u32 wide (as most new qcom SoCs set #address- and >>> #size-cells to <2>). However, that is not the case for all of the >>> SoCs. >> >> Hm, which device of that SoC cannot be used with address/size cells 2? > > As noted in the git log already the geniqup on sm6115 / sm4250 cannot > be used with address/size cells 2 (See: > https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/sm6115.dtsi#L795) SM6115 (and pretty much every other arm64 msm platform newer than 8916) should be using addr/size-cells = 2 along with (dma-)ranges of 36 bit, as that's what their smmus use and otherwise some addresses may get cut off in translation, or so the story went with 845 N years ago.. We can either pursue this patch or I can submit the 2-cell-ification if you don't plan on adding more nodes shortly Konrad > >>> So, ideally we shouldn't set the "#address-cells" and "#size-cells": >>> as const: 2 in the bindings. >>> >>> See as an example: >>> https://www.kernel.org/doc/Documentation/devicetree/bindings/usb/usb-device.yaml >> >> >> How USB device - so entirely different device, not MMIO! - is related here? >> >> Best regards, >> Krzysztof >>