Re: [PATCH 4/4] ARM: dts: stm32: add initial support for stm32mp157-ultra-fly-sbc board

[Goran Radenovic <goran.radni@gmail.com>]

Thank You for the feedback. I will fix this. I have to solve the problem 
with my e-mails in MAINTAINERS first, because I cannot use them to send 
e-mails "inline".

Best regards
Goran


On 10.03.25 17:08, Krzysztof Kozlowski wrote:
> On 10/03/2025 16:48, Goran Rađenović wrote:
>> +&gpioj {
>> +	gpio-line-names =
>> +	"", "", "", "", "", "", "", "",
>> +	"", "", "", "", "", "", "", "";
>> +};
>> +
>> +&gpiok {
>> +	gpio-line-names =
>> +	"", "", "", "", "", "", "", "",
>> +	"", "", "", "", "", "", "", "";
>> +};
>> +
>> +&gpioz {
>> +	gpio-line-names =
>> +	"", "", "", "#SPI_CS2", "", "", "", "",
>> +	"", "", "", "", "", "", "", "";
>> +};
>> +
>> +&gpu {
>> +	status = "okay";
>> +};
>> +
>> +&i2c1 {
>> +	pinctrl-names = "default", "sleep";
>> +	pinctrl-0 = <&i2c1_ux_pins_a>;
>> +	pinctrl-1 = <&i2c1_ux_pins_sleep_a>;
>> +	i2c-scl-rising-time-ns = <100>;
>> +	i2c-scl-falling-time-ns = <7>;
>> +	status = "okay";
>> +	/delete-property/dmas;
>> +	/delete-property/dma-names;
>> +
>> +	rtc@32 {
>> +		compatible = "epson,rx8900";
>> +		reg = <0x32>;
>> +		epson,vdet-disable;
>> +		trickle-diode-disable;
>> +	};
>> +};
>> +
>> +&i2c4 {
>> +	pinctrl-names = "default", "sleep";
>> +	pinctrl-0 = <&i2c4_ux_pins_a>;
>> +	pinctrl-1 = <&i2c4_ux_pins_sleep_a>;
>> +	i2c-scl-rising-time-ns = <185>;
>> +	i2c-scl-falling-time-ns = <20>;
>> +	status = "okay";
>> +	/delete-property/dmas;
>> +	/delete-property/dma-names;
>> +
>> +	pmic: stpmic@33 {
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> pmic?
>
>> +		compatible = "st,stpmic1";
>> +		reg = <0x33>;
>> +		interrupts-extended = <&exti 0 IRQ_TYPE_EDGE_FALLING>;
>> +		interrupt-controller;
>> +		#interrupt-cells = <2>;
>> +		status = "okay";
> Does not look disabled
>
>
> ...
>
>
>> +	dac_ux_ch2_pins_a: dac_ux-ch2-0 {
> No underscores in node names.
>
>> +		pins {
>> +			pinmux = <STM32_PINMUX('A', 5, ANALOG)>;
>> +		};
>> +	};
>> +
>
>
>
> Best regards,
> Krzysztof