devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gokul Sriram Palanisamy <gokul.sriram.p@oss.qualcomm.com>,
	andersson@kernel.org, mathieu.poirier@linaro.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	konradybcio@kernel.org, quic_mmanikan@quicinc.com,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: quic_srichara@quicinc.com, vignesh.viswanathan@oss.qualcomm.com
Subject: Re: [PATCH V5 2/6] dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL
Date: Fri, 25 Apr 2025 08:22:50 +0200	[thread overview]
Message-ID: <23f0efae-9d37-45cd-85df-7122843fece0@kernel.org> (raw)
In-Reply-To: <20250417061245.497803-3-gokul.sriram.p@oss.qualcomm.com>

On 17/04/2025 08:12, Gokul Sriram Palanisamy wrote:
> +  interrupts:
> +    items:
> +      - description: Watchdog interrupt
> +      - description: Fatal interrupt
> +      - description: Ready interrupt
> +      - description: Handover interrupt
> +      - description: Stop acknowledge interrupt
> +
> +  interrupt-names:
> +    items:
> +      - const: wdog
> +      - const: fatal
> +      - const: ready
> +      - const: handover
> +      - const: stop-ack
> +
> +  clocks:
> +    items:
> +      - description: sleep clock
> +
> +  clock-names:
> +    items:
> +      - const: sleep
> +
> +  mboxes:
> +    maxItems: 1
> +    description: A phandle for the TMECom mailbox driver

This is also a new property.

Phandles cannot point to drivers. It is just impossible. It is a phandle
to some device (as in "device node", but we describe here hardware)

Anyway, either drop description if obvious or use simpler form:
  items:
    - description


Best regards,
Krzysztof

  reply	other threads:[~2025-04-25  6:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17  6:12 [PATCH V5 0/6] Add new driver for WCSS secure PIL loading Gokul Sriram Palanisamy
2025-04-17  6:12 ` [PATCH V5 1/6] firmware: qcom_scm: ipq5332: add support to pass metadata size Gokul Sriram Palanisamy
2025-04-17  6:12 ` [PATCH V5 2/6] dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL Gokul Sriram Palanisamy
2025-04-25  6:22   ` Krzysztof Kozlowski [this message]
2025-05-05  4:29     ` Gokul Sriram P
2025-04-17  6:12 ` [PATCH V5 3/6] remoteproc: qcom: add hexagon based WCSS secure PIL driver Gokul Sriram Palanisamy
2025-04-25 11:47   ` Konrad Dybcio
2025-05-05 12:30     ` Gokul Sriram P
2025-05-05 13:07       ` Konrad Dybcio
2025-05-05 13:12         ` Gokul Sriram P
2025-05-05 13:10     ` Gokul Sriram P
2025-04-17  6:12 ` [PATCH V5 4/6] arm64: dts: qcom: ipq5332: add nodes to bringup q6 Gokul Sriram Palanisamy
2025-04-25 20:23   ` Konrad Dybcio
2025-05-15  4:16     ` Gokul Sriram P
2025-05-15  8:15       ` Dmitry Baryshkov
2025-05-15 15:32         ` Konrad Dybcio
2025-04-17  6:12 ` [PATCH V5 5/6] arm64: dts: qcom: ipq5424: add nodes to bring up q6 Gokul Sriram Palanisamy
2025-04-25 20:27   ` Konrad Dybcio
2025-05-05 13:47     ` Gokul Sriram P
2025-05-05 13:53       ` Konrad Dybcio
2025-04-17  6:12 ` [PATCH V5 6/6] arm64: dts: qcom: ipq9574: " Gokul Sriram Palanisamy
2025-04-25 20:29   ` Konrad Dybcio
2025-11-26  5:50     ` Varadarajan Narayanan
2025-11-28 11:09       ` Konrad Dybcio
2025-04-17 13:51 ` [PATCH V5 0/6] Add new driver for WCSS secure PIL loading Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23f0efae-9d37-45cd-85df-7122843fece0@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gokul.sriram.p@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=quic_mmanikan@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=robh@kernel.org \
    --cc=vignesh.viswanathan@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).