From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v3 3/5] arm64: dts: rockchip: add the gmac power domain on rk3399 Date: Thu, 01 Sep 2016 13:41:42 +0200 Message-ID: <2409903.3qiu7FpA8p@diego> References: <1472686132-27827-1-git-send-email-wxt@rock-chips.com> <1472686132-27827-4-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1472686132-27827-4-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Caesar Wang Cc: Mark Rutland , Huang Tao , Brian Norris , Xing Zheng , Elaine Zhang , Masahiro Yamada , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Will Deacon , Douglas Anderson , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Roger Chen , Catalin Marinas , Shunqian Zheng , Jianqun Xu , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, David Wu List-Id: devicetree@vger.kernel.org Hi Caesar, Am Donnerstag, 1. September 2016, 07:28:50 schrieb Caesar Wang: > This patch supports the gmac pd to save power consumption. > Even though some boards not need Ethernet support, the driver > core can also take care of powering up the pd before probe. > > Signed-off-by: Roger Chen > Signed-off-by: Caesar Wang who is the author of this patch? Roger or you? Because we should either drop Roger's Signed-off or fix the authorship to list him. Heiko > --- > > Changes in v3: > - leave into two patches based on patchv2, and fix nits and commit, as > comment on https://patchwork.kernel.org/patch/9306339/ > > Changes in v2: > - Fixes the order, ss Heiko commnets on > https://patchwork.kernel.org/patch/9305991/ > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 32aebc8..2ab233f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -611,6 +611,11 @@ > status = "disabled"; > }; > > + qos_gmac: qos@ffa5c000 { > + compatible = "syscon"; > + reg = <0x0 0xffa5c000 0x0 0x20>; > + }; > + > qos_hdcp: qos@ffa90000 { > compatible = "syscon"; > reg = <0x0 0xffa90000 0x0 0x20>; > @@ -739,6 +744,11 @@ > }; > > /* These power domains are grouped by VD_LOGIC */ > + pd_gmac@RK3399_PD_GMAC { > + reg = ; > + clocks = <&cru ACLK_GMAC>; > + pm_qos = <&qos_gmac>; > + }; > pd_vio@RK3399_PD_VIO { > reg = ; > #address-cells = <1>;