From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6000C8CF; Fri, 22 Dec 2023 08:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="gZTkRA7J" Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 3BM5kUo5029531; Fri, 22 Dec 2023 09:48:59 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=DXnKNS2zZsB/JGQbwoIOXKKoinM3JySMYdHFE4nrpZE=; b=gZ TkRA7JkKE/ZLWoAT+HRyZ9u8wnxdq+/ialw26uKASyNf1c7NtnXE3K4kliKag55X VakRbzK16GQE2JVTbMWGGenrIFfXn0I97np3raSdI+Qd+048BV6hZK0+bJMznTcn 8Y3iJTu4NCiviZ2O+3oL+VVFwxRafZa3skEAroeCNS22v52nqEtPMv8VyoyrEOJM EH9u0QB6Cs6UTvJkNGV4uBvjU3lggSaytQKGkMxh+f+LWrKD+VDZEzhSFxMONcIe RrEl6u1JKG4TolrXFBYxvF+4FoK2O4H5t34zcR9tdSYM72kaQ3vLMpY09+yblKRJ Z95BufTojylX3aM78dCQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3v54ksrm2v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Dec 2023 09:48:59 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 1D82E10004F; Fri, 22 Dec 2023 09:48:40 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 0FB4220B607; Fri, 22 Dec 2023 09:48:40 +0100 (CET) Received: from [10.252.15.82] (10.252.15.82) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 22 Dec 2023 09:48:39 +0100 Message-ID: <24110918-5402-4877-a80f-db1228afeaa1@foss.st.com> Date: Fri, 22 Dec 2023 09:48:38 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] dt-bindings: display: add dt-bindings for STM32 LVDS device Content-Language: en-US To: Krzysztof Kozlowski , Laurent Pinchart , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Yannick Fertre , Philippe Cornu , Philipp Zabel , Lad Prabhakar , Thierry Reding CC: , , , , References: <20231221122843.418650-1-raphael.gallais-pou@foss.st.com> <20231221122843.418650-3-raphael.gallais-pou@foss.st.com> From: Raphael Gallais-Pou In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-22_04,2023-12-21_02,2023-05-22_02 Hi Krzysztof, Thanks for your review. I wall send another serie later with those modifications. Best regards, Raphaël On 12/21/23 18:27, Krzysztof Kozlowski wrote: > On 21/12/2023 13:28, Raphael Gallais-Pou wrote: >> Add dt-binding file for "st,stm32-lvds" compatible. >> > A nit, subject: drop second/last, redundant "dt-bindings for". The > "dt-bindings" prefix is already stating that these are bindings. > >> Signed-off-by: Raphael Gallais-Pou >> --- >> .../bindings/display/st,stm32-lvds.yaml | 114 ++++++++++++++++++ >> 1 file changed, 114 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/st,stm32-lvds.yaml >> > ... > >> +properties: >> + "#clock-cells": >> + const: 0 >> + >> + compatible: >> + const: st,stm32-lvds > Please put compatible as first. > >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: APB peripheral clock >> + - description: Reference clock for the internal PLL >> + >> + clock-names: >> + items: >> + - const: pclk >> + - const: ref >> + >> + resets: >> + maxItems: 1 >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: | >> + LVDS input port node, connected to the LTDC RGB output port. >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: | >> + LVDS output port node, connected to a panel or bridge input port. > Ports are not required? I would assume it won't work without input and > output. > >> + >> +required: >> + - "#clock-cells" >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - ports >> + >> +unevaluatedProperties: false > additionalProperties instead... or did I miss some $ref anywhere? > >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + >> + lvds: lvds@48060000 { >> + #clock-cells = <0>; >> + compatible = "st,stm32-lvds"; > compatible is always the first property. > >> + reg = <0x48060000 0x2000>; > put clock-cells here > >> + clocks = <&rcc CK_BUS_LVDS>, <&rcc CK_KER_LVDSPHY>; >> + clock-names = "pclk", "ref"; >> + resets = <&rcc LVDS_R>; > Best regards, > Krzysztof >