From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 8/9] arm64: dts: rockchip: partially describe PWM regulators for Gru Date: Wed, 07 Dec 2016 17:48:24 +0100 Message-ID: <2418784.7dMdkAyuIx@phil> References: <1480645653-36943-1-git-send-email-briannorris@chromium.org> <1480645653-36943-9-git-send-email-briannorris@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1480645653-36943-9-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Brian Norris Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Chris Zhong , Stephen Barber , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Caesar Wang List-Id: devicetree@vger.kernel.org Hi Brian, Am Donnerstag, 1. Dezember 2016, 18:27:32 CET schrieb Brian Norris: > We need to add regulators to the CPU nodes, so cpufreq doesn't think it > can crank up the clock speed without changing the voltage. However, we > don't yet have the DT bindings to fully describe the Over Voltage > Protection (OVP) circuits on these boards. Without that description, we > might end up changing the voltage too much, too fast. > > Add the pwm-regulator descriptions and associate the CPU OPPs, but leave > them disabled. > > Signed-off-by: Brian Norris is there a specific reason for keeping this change separate? While it is nice for documentation reasons, as it stands now the previous patch introduces a regression (cpufreq trying to scale without regulators) and immediately fixes it here. So if you're ok with it, I'd like to merge this one back into the previous patch when applying. Heiko