From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B29C55178 for ; Mon, 26 Oct 2020 16:05:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B3E622409 for ; Mon, 26 Oct 2020 16:05:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="aZcYCJDW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1774582AbgJZQFK (ORCPT ); Mon, 26 Oct 2020 12:05:10 -0400 Received: from z5.mailgun.us ([104.130.96.5]:55829 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1784900AbgJZQFJ (ORCPT ); Mon, 26 Oct 2020 12:05:09 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603728309; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=gENqlM/pPw1+/3BMakG5icMgcmU6s9phV5kM80xNKFU=; b=aZcYCJDWRxe+d5rbtGZqvkeI5oWkjXZdmfsOwd7cYFKGhRs3wM+Ondg4kkzuhHoacbrPNCMw S2qube/L2CVmd0jKpGo6wciLcVPZrUyJPrwmvfdefvSCJnSQaCwQvSXBVO6SnQO0/WoLYCem zVfCOZ5qSUjWZ0+WVbqy1JxtwHs= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5f96f3993ecd8ffc948de9dd (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 26 Oct 2020 16:04:41 GMT Sender: srivasam=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8F812C433B6; Mon, 26 Oct 2020 16:04:40 +0000 (UTC) Received: from [192.168.29.24] (unknown [49.37.139.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: srivasam) by smtp.codeaurora.org (Postfix) with ESMTPSA id E802BC433FF; Mon, 26 Oct 2020 16:04:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E802BC433FF Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=srivasam@codeaurora.org Subject: Re: [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions To: Srinivas Kandagatla , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: V Sujith Kumar Reddy References: <1603373219-19374-1-git-send-email-srivasam@codeaurora.org> <335f1d55-8a85-8501-fd69-0397f44e21af@linaro.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm India Private Limited. Message-ID: <242284b2-ca3f-fbe0-af97-c0e8e5fe640d@codeaurora.org> Date: Mon, 26 Oct 2020 21:34:32 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <335f1d55-8a85-8501-fd69-0397f44e21af@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thanks for your time srinivas!!! On 10/26/2020 8:31 PM, Srinivas Kandagatla wrote: > > > On 22/10/2020 14:26, Srinivasa Rao Mandadapu wrote: >> From: V Sujith Kumar Reddy >> >> Update SC7180 lpass_variant structure with proper I2S bitwidth >> field bit positions, as bitwidth denotes 0 to 1 bits, >> but previously used only 0 bit. >> >> Fixes: commit cba62c8b49bead ("Merge series "ASoC: qcom: Add support >> for SC7180 lpass variant" from Rohit kumar :") > this should be 12 chars long, for this particular fix it should be! > > Fixes: 24caf8d9eb108 ("ASoC: qcom: lpass-sc7180: Add platform driver > for lpass audio") >> > > No empty line after Fixes tag! > > Will coorect it in next patch. >> Signed-off-by: V Sujith Kumar Reddy >> Signed-off-by: Srinivasa Rao Mandadapu >> --- >>   sound/soc/qcom/lpass-sc7180.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/qcom/lpass-sc7180.c >> b/sound/soc/qcom/lpass-sc7180.c >> index c6292f9e..bc998d5 100644 >> --- a/sound/soc/qcom/lpass-sc7180.c >> +++ b/sound/soc/qcom/lpass-sc7180.c >> @@ -188,7 +188,7 @@ static struct lpass_variant sc7180_data = { >>       .micmode        = REG_FIELD_ID(0x1000, 4, 8, 3, 0x1000), >>       .micmono        = REG_FIELD_ID(0x1000, 3, 3, 3, 0x1000), >>       .wssrc            = REG_FIELD_ID(0x1000, 2, 2, 3, 0x1000), >> -    .bitwidth        = REG_FIELD_ID(0x1000, 0, 0, 3, 0x1000), >> +    .bitwidth        = REG_FIELD_ID(0x1000, 0, 1, 3, 0x1000), >>         .rdma_dyncclk        = REG_FIELD_ID(0xC000, 21, 21, 5, 0x1000), >>       .rdma_bursten        = REG_FIELD_ID(0xC000, 20, 20, 5, 0x1000), >> > --srini -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.