From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ed Wildgoose <lists@wildgooses.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Ed Wildgoose <lists@wildgooses.com>
Subject: Re: [PATCH 0/2] arm64: dts: rockchip: fix dma and pinctrl defs v2
Date: Thu, 18 Sep 2025 18:20:06 +0200 [thread overview]
Message-ID: <2424735.BjyWNHgNrj@diego> (raw)
In-Reply-To: <20250918093246.15623-1-lists@wildgooses.com>
Hi Ed,
Am Donnerstag, 18. September 2025, 11:32:44 Mitteleuropäische Sommerzeit schrieb Ed Wildgoose:
> Based on feedback, I reworked these patches. I've re-presented both as
> I realise that one had invalid formatting (spaces vs tabs) and I've
> moved the dma-names definition into the same board level dtsi. At this
> point it seems reasonable to also squash the two patches, but feedback
> appreciated?
>
> The default pinctrl definitions for the Radxa Zero 3W don't match the
> datasheet. Possibly few people enable extra UARTs and hence it wasn't
> noticed? I needed all 5 UARTs for a project and the first patch corrects
> the pinctrl defs. Without this patch, enabling the extra UARTs causes
> issues such as the MMC devices disappearing, due to collisions.
>
> Second patch adds a dma-names property, which appears to be a
> pre-requisite for enabling DMA on the UARTs. I've applied this to the
> board level dts as feedback suggested there could be unintended problems
> if enabled across the complete rockchip dtsi.
>
> It's tested on my Zero 3W board and appears to function correctly and
> DMA is reported as enabled.
housekeeping requests:
- please don't attach new versions to an old thread, but instead
start a new thread
- this is supposed to be v2, so patches should be named
"[PATCH v2 0/2] ..." etc.
At least the cover-letter should contain a changelog what changed
between versions.
Heiko
prev parent reply other threads:[~2025-09-18 16:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 11:49 [PATCH 0/2] arm64: dts: rockchip: fix dma and pinctrl defs Ed Wildgoose
2025-09-17 11:49 ` [PATCH 1/2] arm64: dts: rockchip: correct uart mux for Radxa ZERO 3 Ed Wildgoose
2025-09-18 4:53 ` FUKAUMI Naoki
2025-09-18 15:23 ` Ed W
2025-09-18 16:18 ` [PATCH 1/2] arm64: dts: rockchip: correct uart mux for Radxa ZERO3 Heiko Stübner
2025-09-18 23:57 ` FUKAUMI Naoki
2025-09-19 9:28 ` Ed W
2025-09-19 10:17 ` Heiko Stübner
2025-09-19 10:21 ` FUKAUMI Naoki
2025-09-19 0:13 ` [PATCH 1/2] arm64: dts: rockchip: correct uart mux for Radxa ZERO 3 FUKAUMI Naoki
2025-09-20 8:14 ` Jonas Karlman
2025-09-17 11:49 ` [PATCH 2/2] rockchip: dts: Enable UART DMA by adding default dma-names property Ed Wildgoose
2025-09-17 12:22 ` Dragan Simic
2025-09-17 14:25 ` Heiko Stübner
2025-09-18 9:32 ` [PATCH 0/2] arm64: dts: rockchip: fix dma and pinctrl defs v2 Ed Wildgoose
2025-09-18 9:32 ` [PATCH 1/2] arm64: dts: rockchip: correct uart mux for Radxa ZERO 3 Ed Wildgoose
2025-09-18 9:32 ` [PATCH 2/2] rockchip: dts: Enable UART DMA by adding default dma-names property Ed Wildgoose
2025-09-18 16:22 ` Heiko Stübner
2025-09-18 16:20 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2424735.BjyWNHgNrj@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lists@wildgooses.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).