From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org
Subject: Re: [PATCH v2 2/8] irqchip: Supply new driver for STi based devices
Date: Tue, 25 Nov 2014 21:57:07 +0100 [thread overview]
Message-ID: <2433040.4NqTrOMmEE@wuerfel> (raw)
In-Reply-To: <1416932705-16880-3-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Tuesday 25 November 2014 16:24:59 Lee Jones wrote:
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index b21f12f..e502f15 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -93,6 +93,13 @@ config RENESAS_IRQC
> bool
> select IRQ_DOMAIN
>
> +config ST_IRQCHIP
> + bool
> + select REGMAP
> + select MFD_SYSCON
> + help
> + Enables SysCfg Controlled IRQs on STi based platforms.
> +
I'm confused by the purpose of this code. It's apparently a driver
in drivers/irqchip, the Kconfig symbol contains the string IRQCHIP,
yet it doesn't actually register an irq_chip.
Also, the name is a bit too generic, ST has lots of different irqchips,
and this apparently isn't even one of them ;-)
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-25 20:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 16:24 [PATCH v2 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
2014-11-25 16:24 ` [PATCH v2 1/8] dt: bindings: Supply shared ST IRQ defines Lee Jones
2014-11-25 16:24 ` [PATCH v2 2/8] irqchip: Supply new driver for STi based devices Lee Jones
[not found] ` <1416932705-16880-3-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-11-25 20:57 ` Arnd Bergmann [this message]
2014-11-27 9:02 ` Lee Jones
2014-11-27 9:15 ` Arnd Bergmann
2014-11-27 9:29 ` Lee Jones
2014-11-27 9:47 ` Arnd Bergmann
2014-11-27 9:55 ` Lee Jones
2014-11-25 16:25 ` [PATCH v2 3/8] irqchip: irq-st: Add documentation for STi based syscfg IRQs Lee Jones
2014-11-25 16:25 ` [PATCH v2 4/8] ARM: STi: STiH416: Enable Cortex-A9 PMU support Lee Jones
2014-11-25 16:25 ` [PATCH v2 5/8] ARM: STi: STiH416: Enable PMU IRQs Lee Jones
2014-11-25 16:25 ` [PATCH v2 6/8] ARM: STi: STiH407: Enable Cortex-A9 PMU support Lee Jones
2014-11-25 16:25 ` [PATCH v2 7/8] ARM: STi: STiH407: Enable PMU IRQs Lee Jones
2014-11-25 16:25 ` [PATCH v2 8/8] ARM: STI: Ensure requested STi's SysCfg Controlled IRQs are enabled at boot Lee Jones
[not found] ` <1416932705-16880-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-12-15 12:28 ` [PATCH v2 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
2014-12-15 14:10 ` Jason Cooper
[not found] ` <20141215141050.GD967-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-12-15 14:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2433040.4NqTrOMmEE@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).