From: Arnd Bergmann <arnd@arndb.de>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [RFC PATCH v2] drivers: pci: move PCI domain assignment to generic PCI code
Date: Wed, 12 Nov 2014 15:38:26 +0100 [thread overview]
Message-ID: <2433793.KkIZdJTcBW@wuerfel> (raw)
In-Reply-To: <20141112141429.GF6759@red-moon>
On Wednesday 12 November 2014 14:14:29 Lorenzo Pieralisi wrote:
> >
> > Since this is now in the file in which it gets called, you can mark the
> > function itself as 'static' and remove the extern declaration and inline
> > wrapper from the header file. You can also avoid the #ifdef by doing
>
> It is not, it is in driver/pci/pci.c, it is called in probe.c.
>
> Maybe I can move the function to probe.c, but this would leave the
> domain handling in two separate files.
>
> I can't remove the #ifdeffery in that domain_nr in pci_bus is #ifdeffed
> too, unless I remove that #ifdef and I compile it in all the time.
>
Right, I see. Unless Bjorn has some other preference, I'd just leave it
with your current version then.
Arnd
next prev parent reply other threads:[~2014-11-12 14:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 16:41 [RFC PATCH v2] drivers: pci: move PCI domain assignment to generic PCI code Lorenzo Pieralisi
[not found] ` <1415637706-2195-1-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
2014-11-12 10:09 ` Lorenzo Pieralisi
2014-11-12 10:19 ` Liviu Dudau
2014-11-12 10:39 ` Arnd Bergmann
2014-11-12 14:14 ` Lorenzo Pieralisi
2014-11-12 14:38 ` Arnd Bergmann [this message]
2014-11-19 9:16 ` Yijing Wang
2014-11-19 9:39 ` Lorenzo Pieralisi
2014-12-04 10:36 ` Grant Likely
2014-11-20 22:54 ` Bjorn Helgaas
2014-12-27 10:36 ` Lorenzo Pieralisi
2014-12-28 1:22 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2433793.KkIZdJTcBW@wuerfel \
--to=arnd@arndb.de \
--cc=Catalin.Marinas@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).