* [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi
@ 2017-03-15 8:42 Chris Zhong
[not found] ` <1489567352-3333-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Chris Zhong @ 2017-03-15 8:42 UTC (permalink / raw)
To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Chris Zhong, Mark Yao, David Airlie, Rob Herring, Mark Rutland,
Heiko Stuebner, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
For RK3399, the grf clock should be controlled by dw-mipi-dsi driver,
add the description for this clock.
Signed-off-by: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---
.../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
index 188f6f7..7e17a60 100644
--- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
+++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
@@ -10,7 +10,7 @@ Required properties:
- interrupts: Represent the controller's interrupt to the CPU(s).
- clocks, clock-names: Phandles to the controller's pll reference
clock(ref) and APB clock(pclk). For RK3399, a phy config clock
- (phy_cfg) is additional required. As described in [1].
+ (phy_cfg) and a grf clock(grf) are additional required. As described in [1].
- rockchip,grf: this soc should set GRF regs to mux vopl/vopb.
- ports: contain a port node with endpoint definitions as defined in [2].
For vopb,set the reg = <0> and set the reg = <1> for vopl.
--
2.6.3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1489567352-3333-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>]
* Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi [not found] ` <1489567352-3333-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org> @ 2017-03-15 9:03 ` Heiko Stübner 2017-03-15 9:55 ` Chris Zhong 0 siblings, 1 reply; 4+ messages in thread From: Heiko Stübner @ 2017-03-15 9:03 UTC (permalink / raw) To: Chris Zhong Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Mark Yao, David Airlie, Rob Herring, Mark Rutland, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong: > For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, > add the description for this clock. > > Signed-off-by: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org> > --- > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 > +- 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t > xt > b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t > xt index 188f6f7..7e17a60 100644 > --- > a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t > xt +++ > b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t > xt @@ -10,7 +10,7 @@ Required properties: > - interrupts: Represent the controller's interrupt to the CPU(s). > - clocks, clock-names: Phandles to the controller's pll reference > clock(ref) and APB clock(pclk). For RK3399, a phy config clock > - (phy_cfg) is additional required. As described in [1]. > + (phy_cfg) and a grf clock(grf) are additional required. As described in > [1]. your "grf" clock is optional, as it is not present on all socs (like the rk3288) so should probably move to a separate section and not be in the required properties Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi 2017-03-15 9:03 ` Heiko Stübner @ 2017-03-15 9:55 ` Chris Zhong 2017-03-15 10:10 ` Heiko Stübner 0 siblings, 1 reply; 4+ messages in thread From: Chris Zhong @ 2017-03-15 9:55 UTC (permalink / raw) To: Heiko Stübner Cc: Mark Rutland, devicetree, linux-kernel, dri-devel, linux-rockchip, Rob Herring, linux-arm-kernel Hi Heiko On 03/15/2017 05:03 PM, Heiko Stübner wrote: > Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong: >> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, >> add the description for this clock. >> >> Signed-off-by: Chris Zhong <zyw@rock-chips.com> >> --- >> >> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 >> +- 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt index 188f6f7..7e17a60 100644 >> --- >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt +++ >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t >> xt @@ -10,7 +10,7 @@ Required properties: >> - interrupts: Represent the controller's interrupt to the CPU(s). >> - clocks, clock-names: Phandles to the controller's pll reference >> clock(ref) and APB clock(pclk). For RK3399, a phy config clock >> - (phy_cfg) is additional required. As described in [1]. >> + (phy_cfg) and a grf clock(grf) are additional required. As described in >> [1]. > your "grf" clock is optional, as it is not present on all socs (like the > rk3288) so should probably move to a separate section and not be in the > required properties For RK3399, the grf clock is required, according to the advice provided by rob[0], put it into "required properties " is better. [0] https://patchwork.kernel.org/patch/9220187/ > > Heiko > > > -- Chris Zhong _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi 2017-03-15 9:55 ` Chris Zhong @ 2017-03-15 10:10 ` Heiko Stübner 0 siblings, 0 replies; 4+ messages in thread From: Heiko Stübner @ 2017-03-15 10:10 UTC (permalink / raw) To: Chris Zhong Cc: Mark Rutland, devicetree, linux-kernel, dri-devel, linux-rockchip, Rob Herring, linux-arm-kernel Am Mittwoch, 15. März 2017, 17:55:23 CET schrieb Chris Zhong: > Hi Heiko > > On 03/15/2017 05:03 PM, Heiko Stübner wrote: > > Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong: > >> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, > >> add the description for this clock. > >> > >> Signed-off-by: Chris Zhong <zyw@rock-chips.com> > >> --- > >> > >> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > >> | 2 > >> > >> +- 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> xt > >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> xt index 188f6f7..7e17a60 100644 > >> --- > >> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> xt +++ > >> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip > >> .t > >> > >> xt @@ -10,7 +10,7 @@ Required properties: > >> - interrupts: Represent the controller's interrupt to the CPU(s). > >> - clocks, clock-names: Phandles to the controller's pll reference > >> > >> clock(ref) and APB clock(pclk). For RK3399, a phy config clock > >> > >> - (phy_cfg) is additional required. As described in [1]. > >> + (phy_cfg) and a grf clock(grf) are additional required. As described > >> in > >> [1]. > > > > your "grf" clock is optional, as it is not present on all socs (like the > > rk3288) so should probably move to a separate section and not be in the > > required properties > > For RK3399, the grf clock is required, according to the advice provided > by rob[0], > put it into "required properties " is better. > [0] https://patchwork.kernel.org/patch/9220187/ ok, but it should probably be made clear, that this is rk3399-specific _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-15 10:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-15 8:42 [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Chris Zhong
[not found] ` <1489567352-3333-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-03-15 9:03 ` Heiko Stübner
2017-03-15 9:55 ` Chris Zhong
2017-03-15 10:10 ` Heiko Stübner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).