From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Akhil P Oommen <quic_akhilpo@quicinc.com>,
freedreno <freedreno@lists.freedesktop.org>,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Will Deacon <will@kernel.org>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Sean Paul <sean@poorly.run>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] drm/msm/adreno: Introduce gmu_chipid for a740 & a750
Date: Sat, 29 Jun 2024 15:06:22 +0200 [thread overview]
Message-ID: <243c0432-a681-4932-957b-e80f2f4ef295@linaro.org> (raw)
In-Reply-To: <20240629015111.264564-4-quic_akhilpo@quicinc.com>
On 29.06.2024 3:49 AM, Akhil P Oommen wrote:
> To simplify, introduce the new gmu_chipid for a740 & a750 GPUs.
>
> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
> ---
This gets rid of getting patchid from dts, but I suppose that's fine,
as we can just add a new entry to the id table
[...]
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -771,7 +771,7 @@ static int a6xx_gmu_fw_start(struct a6xx_gmu *gmu, unsigned int state)
> struct adreno_gpu *adreno_gpu = &a6xx_gpu->base;
> const struct a6xx_info *a6xx_info = adreno_gpu->info->a6xx;
> u32 fence_range_lower, fence_range_upper;
> - u32 chipid, chipid_min = 0;
> + u32 chipid = 0;
The initialization doesn't seem necessary
otherwise:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2024-06-29 13:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 1:49 [PATCH v2 0/5] Support for Adreno X1-85 GPU Akhil P Oommen
2024-06-29 1:49 ` [PATCH v2 1/5] dt-bindings: display/msm/gmu: Add Adreno X185 GMU Akhil P Oommen
2024-06-29 1:49 ` [PATCH v2 2/5] drm/msm/adreno: Add support for X185 GPU Akhil P Oommen
2024-06-29 13:04 ` Konrad Dybcio
2024-06-29 1:49 ` [PATCH v2 3/5] drm/msm/adreno: Introduce gmu_chipid for a740 & a750 Akhil P Oommen
2024-06-29 13:06 ` Konrad Dybcio [this message]
2024-07-01 5:51 ` Akhil P Oommen
2024-06-29 1:49 ` [PATCH v2 4/5] dt-bindings: arm-smmu: Add X1E80100 GPU SMMU Akhil P Oommen
2024-06-29 1:49 ` [PATCH v2 5/5] arm64: dts: qcom: x1e80100: Add gpu support Akhil P Oommen
2024-06-29 13:07 ` Konrad Dybcio
2024-06-29 2:00 ` [PATCH v2 0/5] Support for Adreno X1-85 GPU Akhil P Oommen
2024-07-02 18:43 ` Will Deacon
2024-07-03 3:37 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=243c0432-a681-4932-957b-e80f2f4ef295@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).