From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amelie DELAUNAY Subject: Re: [PATCH 3/6] gpio: Add GPIO support for the ST Multi-Function eXpander Date: Thu, 22 Feb 2018 15:33:31 +0000 Message-ID: <2440a092-507d-bc39-6ed6-4a4ee094da7a@st.com> References: <1518100057-23234-1-git-send-email-amelie.delaunay@st.com> <1518100057-23234-4-git-send-email-amelie.delaunay@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Linus Walleij Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Alexandre TORGUE , Russell King , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Rob Herring , Maxime Coquelin , Lee Jones , Linux ARM List-Id: devicetree@vger.kernel.org On 02/22/2018 02:47 PM, Linus Walleij wrote: > On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay wrote: > >> ST Multi-Function eXpander (MFX) can be used as GPIO expander. >> It has 16 fast GPIOs and can have 8 extra alternate GPIOs >> when other MFX features are not enabled. >> >> Signed-off-by: Amelie Delaunay > > As mentioned I think this driver needs to: > > - Move to drivers/pinctrl/pinctrl-stmfx.c similar to the sx150x controller. > - Pass a regmap around instead of the custom accessor functions. I study this right now! Thanks, Amelie > - Maybe refactor and reuse STMPE infrastructure > > Yours, > Linus Walleij >