* [PATCH] arm64: dts: rockchip: aliase sdhci as mmc0 for rk3566 box demo @ 2024-12-21 10:49 Andy Yan 2024-12-21 12:55 ` Heiko Stübner 2025-04-07 7:17 ` Heiko Stuebner 0 siblings, 2 replies; 5+ messages in thread From: Andy Yan @ 2024-12-21 10:49 UTC (permalink / raw) To: heiko Cc: dsimic, devicetree, linux-arm-kernel, linux-kernel, linux-rockchip, krzk+dt, Andy Yan From: Andy Yan <andy.yan@rock-chips.com> Follow most others rk356x based boards, and u-boot only use mmc0/1 as mmc boot targets, so aliase sdhci as mmc0. Signed-off-by: Andy Yan <andy.yan@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts index 41b4cd5a4220..7d0eedf1bd0d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts @@ -19,9 +19,9 @@ / { aliases { ethernet0 = &gmac1; - mmc0 = &sdmmc0; - mmc1 = &sdmmc1; - mmc2 = &sdhci; + mmc0 = &sdhci; + mmc1 = &sdmmc0; + mmc2 = &sdmmc1; }; chosen: chosen { -- 2.34.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: aliase sdhci as mmc0 for rk3566 box demo 2024-12-21 10:49 [PATCH] arm64: dts: rockchip: aliase sdhci as mmc0 for rk3566 box demo Andy Yan @ 2024-12-21 12:55 ` Heiko Stübner 2024-12-22 6:55 ` Andy Yan 2025-04-07 7:17 ` Heiko Stuebner 1 sibling, 1 reply; 5+ messages in thread From: Heiko Stübner @ 2024-12-21 12:55 UTC (permalink / raw) To: Andy Yan Cc: dsimic, devicetree, linux-arm-kernel, linux-kernel, linux-rockchip, krzk+dt, Andy Yan Hi Andy, Am Samstag, 21. Dezember 2024, 11:49:07 CET schrieb Andy Yan: > From: Andy Yan <andy.yan@rock-chips.com> > > Follow most others rk356x based boards, and u-boot only use mmc0/1 > as mmc boot targets, so aliase sdhci as mmc0. > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > --- > > arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts > index 41b4cd5a4220..7d0eedf1bd0d 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts > @@ -19,9 +19,9 @@ / { > > aliases { > ethernet0 = &gmac1; > - mmc0 = &sdmmc0; > - mmc1 = &sdmmc1; > - mmc2 = &sdhci; > + mmc0 = &sdhci; > + mmc1 = &sdmmc0; > + mmc2 = &sdmmc1; sorry, but that won't be possible :-( . The original aliases for the mmc order were added over 2 years ago (november 2022) and became part of the ABI then. Imagine someone using that board with a rootfs=/dev/mmcblk2p1 part in the commandline to mount the old sdhci-part1 as rootfs, but now you reorder the controllers, so so that commandline would try to access sdmmc1, so their system won't boot anymore after just a simple kernel update. Breaking people's setup is one of those big no-go-s in the kernel, so sadly you'll need to live with the existing order. Heiko ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re:Re: [PATCH] arm64: dts: rockchip: aliase sdhci as mmc0 for rk3566 box demo 2024-12-21 12:55 ` Heiko Stübner @ 2024-12-22 6:55 ` Andy Yan 2025-03-20 12:56 ` Andy Yan 0 siblings, 1 reply; 5+ messages in thread From: Andy Yan @ 2024-12-22 6:55 UTC (permalink / raw) To: Heiko Stübner Cc: dsimic, devicetree, linux-arm-kernel, linux-kernel, linux-rockchip, krzk+dt, Andy Yan Hi Heiko， At 2024-12-21 20:55:02, "Heiko Stübner" <heiko@sntech.de> wrote: >Hi Andy, > >Am Samstag, 21. Dezember 2024, 11:49:07 CET schrieb Andy Yan: >> From: Andy Yan <andy.yan@rock-chips.com> >> >> Follow most others rk356x based boards, and u-boot only use mmc0/1 >> as mmc boot targets, so aliase sdhci as mmc0. >> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com> >> --- >> >> arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts >> index 41b4cd5a4220..7d0eedf1bd0d 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts >> @@ -19,9 +19,9 @@ / { >> >> aliases { >> ethernet0 = &gmac1; >> - mmc0 = &sdmmc0; >> - mmc1 = &sdmmc1; >> - mmc2 = &sdhci; >> + mmc0 = &sdhci; >> + mmc1 = &sdmmc0; >> + mmc2 = &sdmmc1; > >sorry, but that won't be possible :-( . > >The original aliases for the mmc order were added over 2 years ago >(november 2022) and became part of the ABI then. Yes, the patch for this board was submitted by me. This is a tv box evaluation demo board that we use internally，and it is not sold to the public. I submitted it to the mainline because it is small, compact and streamlined, it easy for me to use it test the mainline vop2 driver. I think i am currently the only user who will use this board run the mainline kernel. I'm not sure if we can let it go. > >Imagine someone using that board with a rootfs=/dev/mmcblk2p1 part >in the commandline to mount the old sdhci-part1 as rootfs, but now >you reorder the controllers, so so that commandline would try to access >sdmmc1, so their system won't boot anymore after just a simple kernel >update. > >Breaking people's setup is one of those big no-go-s in the kernel, so >sadly you'll need to live with the existing order. > > >Heiko > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re:Re:Re: [PATCH] arm64: dts: rockchip: aliase sdhci as mmc0 for rk3566 box demo 2024-12-22 6:55 ` Andy Yan @ 2025-03-20 12:56 ` Andy Yan 0 siblings, 0 replies; 5+ messages in thread From: Andy Yan @ 2025-03-20 12:56 UTC (permalink / raw) To: Heiko Stübner Cc: dsimic, devicetree, linux-arm-kernel, linux-kernel, linux-rockchip, krzk+dt, Andy Yan Hi Heiko， At 2024-12-22 14:55:09, "Andy Yan" <andyshrk@163.com> wrote: > >Hi Heiko， >At 2024-12-21 20:55:02, "Heiko Stübner" <heiko@sntech.de> wrote: >>Hi Andy, >> >>Am Samstag, 21. Dezember 2024, 11:49:07 CET schrieb Andy Yan: >>> From: Andy Yan <andy.yan@rock-chips.com> >>> >>> Follow most others rk356x based boards, and u-boot only use mmc0/1 >>> as mmc boot targets, so aliase sdhci as mmc0. >>> >>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com> >>> --- >>> >>> arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts >>> index 41b4cd5a4220..7d0eedf1bd0d 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts >>> @@ -19,9 +19,9 @@ / { >>> >>> aliases { >>> ethernet0 = &gmac1; >>> - mmc0 = &sdmmc0; >>> - mmc1 = &sdmmc1; >>> - mmc2 = &sdhci; >>> + mmc0 = &sdhci; >>> + mmc1 = &sdmmc0; >>> + mmc2 = &sdmmc1; >> >>sorry, but that won't be possible :-( . >> >>The original aliases for the mmc order were added over 2 years ago >>(november 2022) and became part of the ABI then. > >Yes, the patch for this board was submitted by me. >This is a tv box evaluation demo board that we use internally，and it is not sold to the public. >I submitted it to the mainline because it is small, compact and streamlined, it easy for me >to use it test the mainline vop2 driver. >I think i am currently the only user who will use this board run the mainline kernel. >I'm not sure if we can let it go. So far, no one has come forward to claim that they are using this board. Actually, as I mentioned before, currently, it is only me who is using this board to do some DRM-related tests. Could you consider merging it? If later on someone really comes forward and claims that this modification has affected it, we can still revert this patch. > > >> >>Imagine someone using that board with a rootfs=/dev/mmcblk2p1 part >>in the commandline to mount the old sdhci-part1 as rootfs, but now >>you reorder the controllers, so so that commandline would try to access >>sdmmc1, so their system won't boot anymore after just a simple kernel >>update. >> >>Breaking people's setup is one of those big no-go-s in the kernel, so >>sadly you'll need to live with the existing order. >> >> >>Heiko >> >> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: aliase sdhci as mmc0 for rk3566 box demo 2024-12-21 10:49 [PATCH] arm64: dts: rockchip: aliase sdhci as mmc0 for rk3566 box demo Andy Yan 2024-12-21 12:55 ` Heiko Stübner @ 2025-04-07 7:17 ` Heiko Stuebner 1 sibling, 0 replies; 5+ messages in thread From: Heiko Stuebner @ 2025-04-07 7:17 UTC (permalink / raw) To: Andy Yan Cc: Heiko Stuebner, dsimic, devicetree, linux-arm-kernel, linux-kernel, linux-rockchip, krzk+dt, Andy Yan On Sat, 21 Dec 2024 18:49:07 +0800, Andy Yan wrote: > Follow most others rk356x based boards, and u-boot only use mmc0/1 > as mmc boot targets, so aliase sdhci as mmc0. > > Applied, thanks! [1/1] arm64: dts: rockchip: aliase sdhci as mmc0 for rk3566 box demo commit: b6490faab67c4436abeddb5c9e1fb0e8791d58ad Best regards, -- Heiko Stuebner <heiko@sntech.de> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-04-07 7:17 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-12-21 10:49 [PATCH] arm64: dts: rockchip: aliase sdhci as mmc0 for rk3566 box demo Andy Yan 2024-12-21 12:55 ` Heiko Stübner 2024-12-22 6:55 ` Andy Yan 2025-03-20 12:56 ` Andy Yan 2025-04-07 7:17 ` Heiko Stuebner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).