From: Krzysztof Kozlowski <krzk@kernel.org>
To: Janani Sunil <jan.sun97@gmail.com>,
Janani Sunil <janani.sunil@analog.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
gastmaier@gmail.com
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add max22007
Date: Thu, 15 Jan 2026 22:02:42 +0100 [thread overview]
Message-ID: <2443b9d5-788c-4e26-ab1d-fb75853ad936@kernel.org> (raw)
In-Reply-To: <5b3cc813-9244-4ff2-b00a-cc8dbab7e144@gmail.com>
On 15/01/2026 11:24, Janani Sunil wrote:
> Hi Krzysztof,
>
> On 1/15/26 10:24, Krzysztof Kozlowski wrote:
>> On Wed, Jan 14, 2026 at 05:17:01PM +0100, Janani Sunil wrote:
>>> Devicetree bindings for MAX22007 4-channel
>>> 12-bit DAC that drives a voltage or current
>>> output on each channel
>> What is happening with this patchset - why are you making somehow
>> unrelated, different, unexpected and incorrect changes like ones above?
>>
>> You are supposed to work with Git e.g. on dedicated branch, so you
>> clearly see what you did. Why doing such changes?
>
> Apologies for the confusion- this was my mistake.
>
> I picked up V1 of the patch by accident. I'll rework it to address the incorrect changes and will resend the corrected version.
How "picked"? You are supposed to have them in your git, on your
dedicated git branch for example. They cannot be "picked" or "unpicked"
because they are already there and you only add incremental changes
which you squash or commit amend. Really proficiency of Git is absolute
basic in kernel development.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-15 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 16:17 [PATCH v3 0/2] iio: dac: Add support for MAX22007 DAC Janani Sunil
2026-01-14 16:17 ` [PATCH v3 1/2] dt-bindings: iio: dac: Add max22007 Janani Sunil
2026-01-15 9:24 ` Krzysztof Kozlowski
2026-01-15 9:25 ` Krzysztof Kozlowski
2026-01-15 10:24 ` Janani Sunil
2026-01-15 21:02 ` Krzysztof Kozlowski [this message]
2026-01-14 16:17 ` [PATCH v3 2/2] iio: dac: Add MAX22007 DAC driver support Janani Sunil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2443b9d5-788c-4e26-ab1d-fb75853ad936@kernel.org \
--to=krzk@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gastmaier@gmail.com \
--cc=jan.sun97@gmail.com \
--cc=janani.sunil@analog.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox