From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix RK3328 UART DMAs
Date: Fri, 16 Feb 2018 10:20:27 +0100 [thread overview]
Message-ID: <2444566.WmOARJqmXO@diego> (raw)
In-Reply-To: <564d3e93476ae7480f927b1137ec4d0301938f16.1518702332.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
Am Donnerstag, 15. Februar 2018, 14:46:50 CET schrieb Robin Murphy:
> Using a serial console on RK3328 provokes an error from
> of_dma_request_slave_channel() since the UART nodes have a "dmas"
> property but are missing the mandatory "dma-names" to go with it.
>
> Replace the bogus "#dma-cells" - these UARTs are DMA channel consumers,
> not providers - with the appropriate names instead. DMA still doesn't
> actually work, since the PL330 driver doesn't quite implement everything
> the 8250 driver demands, but at least it makes the DT correct.
>
> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
applied for 4.17
Thanks for the catch
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-02-16 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 13:46 [PATCH] arm64: dts: rockchip: Fix RK3328 UART DMAs Robin Murphy
[not found] ` <564d3e93476ae7480f927b1137ec4d0301938f16.1518702332.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2018-02-16 9:20 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2444566.WmOARJqmXO@diego \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).