From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE326C76196 for ; Thu, 6 Apr 2023 18:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239918AbjDFSlN convert rfc822-to-8bit (ORCPT ); Thu, 6 Apr 2023 14:41:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbjDFSlM (ORCPT ); Thu, 6 Apr 2023 14:41:12 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA79E5BA9; Thu, 6 Apr 2023 11:41:08 -0700 (PDT) Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pkUXX-0000O3-65; Thu, 06 Apr 2023 20:40:55 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring , Krzysztof Kozlowski , Cristian Ciocaltea , Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, kernel@collabora.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: (subset) [PATCH v2 0/2] Add PWM fan support to Rock 5B board Date: Thu, 06 Apr 2023 20:40:53 +0200 Message-ID: <2446486.yKVeVyVuyW@diego> In-Reply-To: <31a5bd88-4121-ac5c-0d8d-eee6b221f1db@roeck-us.net> References: <20230404173807.490520-1-cristian.ciocaltea@collabora.com> <840877554.0ifERbkFSE@diego> <31a5bd88-4121-ac5c-0d8d-eee6b221f1db@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Donnerstag, 6. April 2023, 20:27:33 CEST schrieb Guenter Roeck: > On 4/5/23 14:35, Heiko Stübner wrote: > > Am Mittwoch, 5. April 2023, 21:04:04 CEST schrieb Guenter Roeck: > >> On 4/5/23 10:45, Heiko Stuebner wrote: > >>> On Tue, 4 Apr 2023 20:38:05 +0300, Cristian Ciocaltea wrote: > >>>> This patch series enables support for the PWM controlled heat sink fan > >>>> on the Rock 5B SBC and, additionally, converts the hwmon PWM fan bindings > >>>> to DT schema format. > >>>> > >>>> Changes in v2: > >>>> - Updated PATCH 1/2 according to Rob's review > >>>> - Added Reviewed-by from Christopher to PATCH 2/2 > >>>> - v1: https://lore.kernel.org/lkml/20230403105052.426135-1-cristian.ciocaltea@collabora.com/ > >>>> > >>>> [...] > >>> > >>> Applied, thanks! > >>> > >> > >> Both patches or only the second one ? > > > > only the second one of course. According to earlier talks the dts patch > > does already follow the text binding, so the yaml conversion is actually > > not a requirement for it. > > > > So I picked the dts patch let the binding sort itself when people have > > time for it :-) . > > > > > > Looking at the mail b4 created, I guessed this would also be visible > > with the subject saying (subset) and the listed commits only showing > > > > [2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan > > commit: f36bb17653e4b9e26bbdb1224027d20614e77636 > > > > Kind of, sure, but I figured it doesn't hurt asking to avoid the situation > (again) where I apply a patch and then get a nice e-mail telling me that > some other branch also applied the same patch. no worries and yes better save than sorry. Though you had me worried for a bit that somehow the mail b4 generated for me was faulty ;-) Heiko