From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/2] drm: bridge: Add bindings for TI THS8134 Date: Wed, 13 Sep 2017 03:08:14 +0300 Message-ID: <2446705.uuxjYiEYNm@avalon> References: <20170901094038.4312-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20170901094038.4312-1-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: Archit Taneja , Andrzej Hajda , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bartosz Golaszewski List-Id: devicetree@vger.kernel.org Hi Linus, Thank you for the patch. On Friday, 1 September 2017 12:40:37 EEST Linus Walleij wrote: > This adds device tree bindings for the Texas Instruments > THS8134A and THS8134B VGA DACs by extending and renaming the > existing bindings for THS8135. > > These DACs are used for the VGA outputs on the ARM reference > designs such as Integrator, Versatile and RealView. > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Bartosz Golaszewski > Signed-off-by: Linus Walleij > --- > .../display/bridge/{ti,ths8135.txt => ti,ths813x.txt} | 12 ++++++--- > 1 file changed, 8 insertions(+), 4 deletions(-) > rename Documentation/devicetree/bindings/display/bridge/{ti,ths8135.txt => > ti,ths813x.txt} (73%) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > b/Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt > similarity index 73% > rename from Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > rename to Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt > index 6ec1a880ac18..608435f04796 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths813x.txt > @@ -1,11 +1,15 @@ > -THS8135 Video DAC > ------------------ > +THS8134 and THS8135 Video DAC > +----------------------------- > > -This is the binding for Texas Instruments THS8135 Video DAC bridge. > +This is the binding for Texas Instruments THS8134A, THS8134B and THS8135 > +Video DAC bridge. > > Required properties: > > -- compatible: Must be "ti,ths8135" > +- compatible: Must be one of > + "ti,ths8134a" > + "ti,ths8134b" > + "ti,ths8135" As mentioned in the review of patch 2/2, would it make sense to also introduce a ti,ths813x compatible string ? I haven't checked the datasheets so the answer might very well be no. > Required nodes: -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html