public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sen Wang <sen@ti.com>, linux-sound@vger.kernel.org
Cc: broonie@kernel.org, lgirdwood@gmail.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, perex@perex.cz, tiwai@suse.com,
	shenghao-ding@ti.com, kevin-lu@ti.com, baojun.xu@ti.com,
	niranjan.hy@ti.com, l-badrinarayanan@ti.com, devarsht@ti.com,
	v-singh1@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] ASoC: dt-bindings: Add ti,tas67524
Date: Fri, 3 Apr 2026 09:20:52 +0200	[thread overview]
Message-ID: <2450b3d3-bfa8-453b-9264-f341fe871136@kernel.org> (raw)
In-Reply-To: <20260403050627.635591-2-sen@ti.com>

On 03/04/2026 07:06, Sen Wang wrote:
> Add device tree binding for the Texas Instruments TAS67524 family
> of four-channel Class-D audio amplifiers with integrated DSP.
> 
> Signed-off-by: Sen Wang <sen@ti.com>
> ---
> Changes in v3:
>  - Renamed ti,tas675x to ti,tas67524.yaml
>  - Removed tas6754 compatible instance
>  - Changed pd-gpios to powerdown-gpios
>  - Cleanup unnessary "|" formatting
> 
> Changes in v2:
>  - None
> 
>  .../bindings/sound/ti,tas67524.yaml           | 277 ++++++++++++++++++
>  1 file changed, 277 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ti,tas67524.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas67524.yaml b/Documentation/devicetree/bindings/sound/ti,tas67524.yaml
> new file mode 100644
> index 000000000000..b8da1360e698
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ti,tas67524.yaml
> @@ -0,0 +1,277 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/ti,tas67524.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TAS67524 Audio Amplifier
> +
> +maintainers:
> +  - Sen Wang <sen@ti.com>
> +
> +description:
> +  The TAS67524 is a four-channel, digital-input, automotive
> +  Class-D audio amplifier with load diagnostics and an integrated
> +  DSP for audio processing.
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tas67524


And where did you give me chance to answer to your comment? You answered
2:40 AM of my time and four hours later - 7 AM my time - you send v3.

No, read again the feedback. I am not reviewing the rest.

Best regards,
Krzysztof

  reply	other threads:[~2026-04-03  7:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-03  5:06 [PATCH v3 0/4] ASoC: Add TAS67524 quad-channel Class-D amplifier driver Sen Wang
2026-04-03  5:06 ` [PATCH v3 1/4] ASoC: dt-bindings: Add ti,tas67524 Sen Wang
2026-04-03  7:20   ` Krzysztof Kozlowski [this message]
2026-04-03  5:06 ` [PATCH v3 2/4] ASoC: codecs: Add TAS67524 quad-channel audio amplifier driver Sen Wang
2026-04-03  5:06 ` [PATCH v3 3/4] Documentation: sound: Add TAS675x codec mixer controls documentation Sen Wang
2026-04-03  5:06 ` [PATCH v3 4/4] MAINTAINERS: add entry for TAS67524 audio amplifier Sen Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2450b3d3-bfa8-453b-9264-f341fe871136@kernel.org \
    --to=krzk@kernel.org \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kevin-lu@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=l-badrinarayanan@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=niranjan.hy@ti.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=sen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.com \
    --cc=v-singh1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox