Re: [PATCH v1 06/10] media: platform: mediatek: add isp_7x utility

["CK Hu (胡俊光)" <ck.hu@mediatek.com>]

Hi, Shu-hsiang:

On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces utility files for the MediaTek ISP7.x camsys driver. These
> utilities provide essential platform definitions, debugging tools, and
> management functions to support ISP operations and SCP communication.
> Key functionalities include:
> 1.Hardware pipeline and register definitions for managing image
> processing modules.
> 2.DMA debugging utilities and buffer management functions.
> 3.Definitions of supported image formats for proper data handling.
> 4.IPI and SCP communication structures for module state management and
> configuring ISP.
> 5.Metadata parameters for configuring image processing.
> 
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@mediatek.com>
> ---

[snip]

> +static __maybe_unused struct dma_debug_item dbg_PDI_R1[] = {
> +	{0x00000014, "pdi_r1 32(hex) 0000"},

You print this register value, but how to use this value to debug?
What's the error value? Each error value means what kind of error?
Add comment about how to use this value to debug.
If no one knows how to use this value, the debug method is redundant.

> +	{0x00000114, "pdi_r1 state_checksum"},

Ditto.

> +	{0x00000214, "pdi_r1 line_pix_cnt_tmp"},

Ditto.

> +	{0x00000314, "pdi_r1 line_pix_cnt"},

Ditto.

> +	{0x00000414, "pdi_r1 important_status"},

Ditto.

> +	{0x00000514, "pdi_r1 cmd_data_cnt"},

Ditto.

> +	{0x00000614, "pdi_r1 tilex_byte_cnt"},

Ditto.

> +	{0x00000714, "pdi_r1 tiley_cnt"},

Ditto.

> +	{0x00000814, "pdi_r1 burst_line_cnt"},

Ditto.

Regards,
CK

> +};
> +