From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 2/5] [RFC] clk: shmobile: Add r8a7795 CPG Core Clock Definitions Date: Fri, 23 Oct 2015 14:21:04 +0300 Message-ID: <2464036.AexIB1O0H1@avalon> References: <1444999760-15750-1-git-send-email-geert+renesas@glider.be> <1444999760-15750-3-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1444999760-15750-3-git-send-email-geert+renesas@glider.be> Sender: linux-sh-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , Magnus Damm , Simon Horman , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-sh@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Geert, Thank you for the patch. On Friday 16 October 2015 14:49:17 Geert Uytterhoeven wrote: > Add all R-Car H3 CPG Core Clock Outputs defined in the datasheet. > > Signed-off-by: Geert Uytterhoeven > --- > v4: > - Add all clocks instead of just the ones used by the current DTS. > > v3: > - New. > --- > include/dt-bindings/clock/r8a7795-cpg-mssr.h | 63 +++++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 include/dt-bindings/clock/r8a7795-cpg-mssr.h > > diff --git a/include/dt-bindings/clock/r8a7795-cpg-mssr.h > b/include/dt-bindings/clock/r8a7795-cpg-mssr.h new file mode 100644 > index 0000000000000000..e864aae0a2561c4b > --- /dev/null > +++ b/include/dt-bindings/clock/r8a7795-cpg-mssr.h > @@ -0,0 +1,63 @@ > +/* > + * Copyright (C) 2015 Renesas Electronics Corp. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ > +#ifndef __DT_BINDINGS_CLOCK_R8A7795_CPG_MSSR_H__ > +#define __DT_BINDINGS_CLOCK_R8A7795_CPG_MSSR_H__ > + > +#include > + > +/* r8a7795 CPG Core Clocks */ > +#define R8A7795_CLK_Z 0 > +#define R8A7795_CLK_Z2 1 > +#define R8A7795_CLK_ZR 2 > +#define R8A7795_CLK_ZG 3 > +#define R8A7795_CLK_ZTR 4 > +#define R8A7795_CLK_ZTRD2 5 > +#define R8A7795_CLK_ZT 6 > +#define R8A7795_CLK_ZX 7 > +#define R8A7795_CLK_S0D1 8 > +#define R8A7795_CLK_S0D4 9 > +#define R8A7795_CLK_S1D1 10 > +#define R8A7795_CLK_S1D2 11 > +#define R8A7795_CLK_S1D4 12 > +#define R8A7795_CLK_S2D1 13 > +#define R8A7795_CLK_S2D2 14 > +#define R8A7795_CLK_S2D4 15 > +#define R8A7795_CLK_S3D1 16 > +#define R8A7795_CLK_S3D2 17 > +#define R8A7795_CLK_S3D4 18 > +#define R8A7795_CLK_LB 19 > +#define R8A7795_CLK_CL 20 > +#define R8A7795_CLK_ZB3 21 > +#define R8A7795_CLK_ZB3D2 22 > +#define R8A7795_CLK_CR 23 > +#define R8A7795_CLK_CRD2 24 > +#define R8A7795_CLK_SD0H 25 > +#define R8A7795_CLK_SD0 26 > +#define R8A7795_CLK_SD1H 27 > +#define R8A7795_CLK_SD1 28 > +#define R8A7795_CLK_SD2H 29 > +#define R8A7795_CLK_SD2 30 > +#define R8A7795_CLK_SD3H 31 > +#define R8A7795_CLK_SD3 32 > +#define R8A7795_CLK_SSP2 33 > +#define R8A7795_CLK_SSP1 34 > +#define R8A7795_CLK_SSPRS 35 > +#define R8A7795_CLK_RPC 36 > +#define R8A7795_CLK_RPCD2 37 > +#define R8A7795_CLK_MSO 38 > +#define R8A7795_CLK_CANFD 39 > +#define R8A7795_CLK_HDMI 40 > +#define R8A7795_CLK_CSI0 41 > +#define R8A7795_CLK_CSIREF 42 > +#define R8A7795_CLK_CP 43 > +#define R8A7795_CLK_CPEX 44 > +#define R8A7795_CLK_R 45 > +#define R8A7795_CLK_OSC 46 Those two clocks are called RCLK and OSCCLK in the datasheet, shouldn't we use those names ? Apart from that, Reviewed-by: Laurent Pinchart > +#endif /* __DT_BINDINGS_CLOCK_R8A7795_CPG_MSSR_H__ */ -- Regards, Laurent Pinchart