From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 2/3] ARM: dts: replace clock numbers with macros for exynos5420 Date: Fri, 20 Dec 2013 23:02:23 +0100 Message-ID: <2478495.7T968MEiJL@flatron> References: <1387544246-31658-1-git-send-email-rahul.sharma@samsung.com> <1387544246-31658-3-git-send-email-rahul.sharma@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1387544246-31658-3-git-send-email-rahul.sharma@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Rahul Sharma Cc: linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mturquette@linaro.org, kgene.kim@samsung.com, thomas.ab@samsung.com, joshi@samsung.com, r.sh.open@gmail.com, Andrzej Hajda List-Id: devicetree@vger.kernel.org Hi Rahul, On Friday 20 of December 2013 18:27:25 Rahul Sharma wrote: > DT nodes contain clock numbers which are referred by drivers > to get the clocks. These numbers are replaced by MACROs > which are defined in the exynos5420-clk.h header file. This is a good idea, but we already have such conversion scheduled for all the existing clock drivers in an automated way. Andrzej Hajda (on CC) has a script that automatically converts DTS files and clock drivers from enums to defines. Also such change needs to be done in a timely manner, due to greatly increasing chance of conflicting other patches. My suggestion is to drop this and patch 3/3 from this series and let us handle this using Andrzej's script at appropriate point of time. > > Signed-off-by: Rahul Sharma > --- > arch/arm/boot/dts/exynos5420.dtsi | 47 +++++++++++++++++++------------------ > 1 file changed, 24 insertions(+), 23 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index e552608..db8b2da 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -17,6 +17,7 @@ > #include "exynos5420-pinctrl.dtsi" > > #include > +#include By the way, this header is added in patch 3/3, so this patch breaks bisectability, which is not acceptable. Best regards, Tomasz