From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes Date: Mon, 27 Jul 2015 03:21:01 -0700 (PDT) Message-ID: <24796517.2pfRdOOmRJ@ubix> References: <1437706925-3222-1-git-send-email-jamesjj.liao@mediatek.com> <1437965782.5614.4.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1437965782.5614.4.camel@mtksdaap41> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: James Liao Cc: Daniel Kurtz , Mike Turquette , Stephen Boyd , Heiko Stubner , srv_heupstream , Ricky Liang , Rob Herring , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Monday, July 27, 2015 10:56:22 AM James Liao wrote: > Hi Daniel, > > On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote: > > > @@ -88,6 +88,13 @@ > > > > > > #clock-cells = <0>; > > > > > > }; > > > > > > + cpum_ck: dummy_clk { > > > > I'm not a big fan of this "dummy_clk". > > The 'name' part of the devicetree node is supposed to be generic. > > So, perhaps just oscillator@2, and move it down below clk32k: > > oscillator@1. > > > Otherwise: > cpum_ck is a test clock which only available in IC test. It's empty on > MT8173 evaluation or production boards. Should we name this kind of > empty clock as an oscillator? Or is there a better name for it? > So if it will never be part of any available boards, why do you want to add it? Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html