devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Herring <robh@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev,
	David Airlie <airlied@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rob Clark <robdclark@gmail.com>,
	freedreno@lists.freedesktop.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org, Sean Paul <sean@poorly.run>,
	Robin Murphy <robin.murphy@arm.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Krishna Manikandan <quic_mkrishn@quicinc.com>,
	linux-arm-kernel@lists.infradead.org,
	Marijn Suijten <marijn.suijten@somainline.org>
Subject: Re: [PATCH v5 04/12] dt-bindings: display/msm: Add SM6350 MDSS
Date: Thu, 1 Jun 2023 03:12:11 +0300	[thread overview]
Message-ID: <247f6b45-a730-4259-9576-a0b63af24d34@linaro.org> (raw)
In-Reply-To: <168483089214.140382.17835176497108911988.robh@kernel.org>

On 23/05/2023 11:34, Rob Herring wrote:
> 
> On Tue, 23 May 2023 09:46:15 +0200, Konrad Dybcio wrote:
>> Document the SM6350 MDSS.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>   .../bindings/display/msm/qcom,sm6350-mdss.yaml     | 214 +++++++++++++++++++++
>>   1 file changed, 214 insertions(+)
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.example.dtb: dsi@ae94000: compatible: 'oneOf' conditional failed, one must be fixed:
> 	['qcom,sm6350-dsi-ctrl', 'qcom,mdss-dsi-ctrl'] is too long
> 	'qcom,sm6350-dsi-ctrl' is not one of ['qcom,apq8064-dsi-ctrl', 'qcom,msm8916-dsi-ctrl', 'qcom,msm8953-dsi-ctrl', 'qcom,msm8974-dsi-ctrl', 'qcom,msm8996-dsi-ctrl', 'qcom,msm8998-dsi-ctrl', 'qcom,qcm2290-dsi-ctrl', 'qcom,sc7180-dsi-ctrl', 'qcom,sc7280-dsi-ctrl', 'qcom,sdm660-dsi-ctrl', 'qcom,sdm845-dsi-ctrl', 'qcom,sm6115-dsi-ctrl', 'qcom,sm8150-dsi-ctrl', 'qcom,sm8250-dsi-ctrl', 'qcom,sm8350-dsi-ctrl', 'qcom,sm8450-dsi-ctrl', 'qcom,sm8550-dsi-ctrl']
> 	'qcom,sm6350-dsi-ctrl' is not one of ['qcom,dsi-ctrl-6g-qcm2290', 'qcom,mdss-dsi-ctrl']
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.example.dtb: dsi@ae94000: Unevaluated properties are not allowed ('compatible' was unexpected)
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml

It looks as if the patches 1 & 2 were not applied when testing this 
patch. I can not reproduce this issue locally. Could you please 
doublecheck it?

> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230411-topic-straitlagoon_mdss-v5-4-998b4d2f7dd1@linaro.org
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

-- 
With best wishes
Dmitry


  reply	other threads:[~2023-06-01  0:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-23  7:46 [PATCH v5 00/12] SM63(50|75) DPU support Konrad Dybcio
2023-05-23  7:46 ` [PATCH v5 01/12] dt-bindings: display/msm: dsi-controller-main: Add SM6350 Konrad Dybcio
2023-05-23  7:46 ` [PATCH v5 02/12] dt-bindings: display/msm: dsi-controller-main: Add SM6375 Konrad Dybcio
2023-05-23  7:46 ` [PATCH v5 03/12] dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375 Konrad Dybcio
2023-06-04 17:57   ` Krzysztof Kozlowski
2023-05-23  7:46 ` [PATCH v5 04/12] dt-bindings: display/msm: Add SM6350 MDSS Konrad Dybcio
2023-05-23  8:34   ` Rob Herring
2023-06-01  0:12     ` Dmitry Baryshkov [this message]
2023-06-04 18:04   ` Krzysztof Kozlowski
2023-05-23  7:46 ` [PATCH v5 05/12] dt-bindings: display/msm: Add SM6375 MDSS Konrad Dybcio
2023-05-23  8:34   ` Rob Herring
2023-06-04 18:04   ` Krzysztof Kozlowski
2023-06-05 17:01     ` Konrad Dybcio
2023-06-05 17:09       ` Dmitry Baryshkov
2023-05-23  7:46 ` [PATCH v5 06/12] drm/msm/dpu: Add SM6350 support Konrad Dybcio
2023-05-23 14:39   ` Dmitry Baryshkov
2023-05-23  7:46 ` [PATCH v5 07/12] drm/msm: mdss: " Konrad Dybcio
2023-05-23  7:46 ` [PATCH v5 08/12] drm/msm/dpu: Add SM6375 support Konrad Dybcio
2023-06-01 14:56   ` Marijn Suijten
2023-06-02  8:56     ` Konrad Dybcio
2023-06-04 18:23     ` Marijn Suijten
2023-05-23  7:46 ` [PATCH v5 09/12] drm/msm: mdss: " Konrad Dybcio
2023-05-23  7:46 ` [PATCH v5 10/12] iommu/arm-smmu-qcom: Sort the compatible list alphabetically Konrad Dybcio
2023-05-23  7:46 ` [PATCH v5 11/12] iommu/arm-smmu-qcom: Add SM6375 DPU compatible Konrad Dybcio
2023-05-23  7:46 ` [PATCH v5 12/12] iommu/arm-smmu-qcom: Add SM6350 " Konrad Dybcio
2023-06-01  0:16 ` [PATCH v5 00/12] SM63(50|75) DPU support Dmitry Baryshkov
2023-06-05 15:43   ` Will Deacon
2023-06-05 15:50     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=247f6b45-a730-4259-9576-a0b63af24d34@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_mkrishn@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sean@poorly.run \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).