From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2] arm64: dts: rockchip: add USB 2.0 and 3.0 support on Ficus board Date: Mon, 16 Jul 2018 19:02:24 +0200 Message-ID: <2487041.HPaZN1uVBU@phil> References: <20180714170922.4433-1-ezequiel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180714170922.4433-1-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Ezequiel Garcia Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Enric Balletbo i Serra , kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Enric, Ezequiel, Am Samstag, 14. Juli 2018, 19:09:22 CEST schrieb Ezequiel Garcia: > From: Enric Balletbo i Serra > > The board exposes two types A ports, one is USB 3.0, up to 5.0Gbps and > another one is USB 2.0 up to 480Mbps. Enable the USB PHYs and the USB > controllers to enable theses devices. > > Signed-off-by: Enric Balletbo i Serra > Signed-off-by: Ezequiel Garcia > --- > Changes from v1: > * Provide voltage for vcc5v0_host and vcc3v3_pcie regulators > * Provide vin_supply for vcc5v0_host. > > arch/arm64/boot/dts/rockchip/rk3399-ficus.dts | 90 +++++++++++++++++++ > 1 file changed, 90 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts b/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > index 0d14183dd4a9..6295483b701f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > @@ -58,9 +58,24 @@ > pinctrl-0 = <&pcie_drv>; > regulator-boot-on; > regulator-name = "vcc3v3_pcie"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > vin-supply = <&vcc3v3_sys>; > }; I've split this out into a separate patch, as it isn't part of what the commit message describes and thus should be separate and applied both resulting patches for 4.19. And also cleaned up a vendor-property that shouldn't be part of mainline. Heiko