From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86A7B629; Thu, 26 Dec 2024 00:45:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735173935; cv=none; b=r/XuMs4BL3AeSmjKBqTTdJgGKb9O8+k4oDsac+c9c6IcKFXyWxZlZu8uZ19QesdU862YnZB2fJBuFo72iC2onKoEFy9X7EX0RUp6WGbj91+dbisxiGznrvegf+OYRqmQNwl6U5FtNi5MyvfO3LP8SvCt9tsRs2QZFiK0XCg20KU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735173935; c=relaxed/simple; bh=i2UYbjxmhxY/sQmPZqGlW9VSS0YAv6tPrTydLh2fL6o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gh0qOQX5IJfvLpl3CKNmF2SeCviNDhvyy+1nHb/5Iyk8fC+vzh931n1yfbLJfYzlsiPJv6SgUk5oMkjypHvXCy+ZxE4UAU4reFzI+y/vVsyLuykC8AsS9FpKKU6NCfpmpm5E/eb5odCAqjVae3QchqzA1OejV1bQ0NuqOoN6uZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=VCFXHsDc; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="VCFXHsDc" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zkiSR+pP4PDYxWoTcL6hKQD8NN/shidqmyYevfYxc1M=; b=VCFXHsDcbePWO7rfKx50ziB8iB Xc22JHTQEz7cWSjudPd+LjHRNVIq+q0EOi9K5o+O7AtCB5gJgtX9gtuz97RSBKha54bXUccx4UJ2p tLBLjVIZBT9rSCpN/cDvqxpdSZ6Uajzb6FdBPA0KgVlwrNmUmst3EPmb4tW7WP8qGZW2G4gw41c7G NizbtmK4ODHD/JWj32cVTM3/DxODIP7T6r/mVmHg88YOC2CLwSoqL1Ma6fV6cADS7gg8DAFYXOHZ8 62mAN1hyIyFEO3avmpi4/eici+pBB3jfepYrtU0aGf0iOrq2Uz5GFHluVzaywh93iXiS8nMIJy6wn JJFhlKUg==; Received: from i53875a54.versanet.de ([83.135.90.84] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tQc0G-0004a5-GZ; Thu, 26 Dec 2024 01:45:28 +0100 From: Heiko Stuebner To: Kever Yang Cc: linux-rockchip@lists.infradead.org, Kever Yang , devicetree@vger.kernel.org, Conor Dooley , Maxime Ripard , Rob Herring , Thomas Zimmermann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Krzysztof Kozlowski , Maarten Lankhorst , Simona Vetter Subject: Re: [PATCH v2 06/17] dt-bindings: gpu: Add rockchip,rk3562-mali compatible Date: Thu, 26 Dec 2024 01:45:27 +0100 Message-ID: <2487077.iZASKD2KPV@phil> In-Reply-To: <20241224094920.3821861-7-kever.yang@rock-chips.com> References: <20241224094920.3821861-1-kever.yang@rock-chips.com> <20241224094920.3821861-7-kever.yang@rock-chips.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Dienstag, 24. Dezember 2024, 10:49:09 CET schrieb Kever Yang: > rk3562 has 1 ARM Mali-G52 GPU,. > > Signed-off-by: Kever Yang > --- > > Changes in v2: None > > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index 735c7f06c24e..b0d4806614aa 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -25,6 +25,7 @@ properties: > - renesas,r9a07g044-mali > - renesas,r9a07g054-mali > - rockchip,px30-mali > + - rockchip,rk3562-mali > - rockchip,rk3568-mali > - rockchip,rk3576-mali > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable > @@ -60,7 +61,7 @@ properties: > > clocks: > minItems: 1 > - maxItems: 3 > + maxItems: 4 The commit message only says something about the rk3562. As it looks like you need another clock, the commit message should definitly explain that. Heiko