From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35208C77B78 for ; Thu, 4 May 2023 14:39:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230495AbjEDOjd (ORCPT ); Thu, 4 May 2023 10:39:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230479AbjEDOjc (ORCPT ); Thu, 4 May 2023 10:39:32 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC18B118 for ; Thu, 4 May 2023 07:39:30 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-957dbae98b4so90243066b.1 for ; Thu, 04 May 2023 07:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683211169; x=1685803169; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RtHFIOyHUHDm6OwF3/rRw5NdicRws7FTGgdEZwPjkL0=; b=B2ywh6muaT5cNRLxTdpb3TEH/PiIrCqdXYixzvXno5GZTT0ZscAElKb2bmGGt2PxHR /OudDMGAa+SYwMxo5fUixcqCVy1/Malqex3Hr8MCOIX3wHyzpLbAXr2kovOg6hdJqacT W8CjMqQZMpaV1oSgry9csxJq6ob8N+tHo9oNEqVJ1Fff8skrMNxBl/rZcVK5MDTOi/TO /ZjkXUFVBynZE2GU7NA4iNZ/iFfAJlEhz7hCm1xOYo/DdETSzbBaFgS2oAroY0CtX0ry 17lAR5bXcJmJK1qpPq/p7NaN8h8NZ8vi5flVyaEx6ACgn9Z0apLJ1a2+GFHftIjAHWTh br4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683211169; x=1685803169; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RtHFIOyHUHDm6OwF3/rRw5NdicRws7FTGgdEZwPjkL0=; b=Id9uvhF2zr7qRpPk5xudlGMfOcYAtWa7xmWr8m7xsCfTnzPmNlW/LPbqsSh/jDAq4C 4yjbrvC9UsT1EOnnJYR56jhbi2vk8kRW4d4pX+rlLSNE0S6zvp0CEWd2IOYVqz9D3IEy 4U0rZ9YcHjxwRNeSnGTgTjS9ckoCbIFfvsk7nvoHcq0ISBAphV/qf7SFRVQhds5ES0X3 Ipm+vb8wHTIJnvAV42nvZZ/LAaRktEzCgYQdBaf5mHi3nnq0F9hWE2CyNJ91tJ5E5ASO l7Gd8lYxaNdgF5xnINcbyhYC5dtnH/aSTveCPkwVOAUMeUITWt3yvIipqbTRJQ5JCp4P Wn4g== X-Gm-Message-State: AC+VfDxpbDTbrWcQTF1dNa8nPIwQAe3rzM2DoiNOvtQGz2QP4Bn0KX76 rdGD+RNimUQeRJ+RzxfomLGVYw== X-Google-Smtp-Source: ACHHUZ7Z3L26zZEhzBRypzDcsBcd1kRVAs82E/aA2e4syMmGyPokB7NYew5voOG/UPvwcxk9Hlq1gA== X-Received: by 2002:a17:907:9693:b0:953:9b27:8f00 with SMTP id hd19-20020a170907969300b009539b278f00mr6645560ejc.74.1683211169112; Thu, 04 May 2023 07:39:29 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:cbf1:e7ef:fb81:e912? ([2a02:810d:15c0:828:cbf1:e7ef:fb81:e912]) by smtp.gmail.com with ESMTPSA id d1-20020a170907272100b00965bf86c00asm302384ejl.143.2023.05.04.07.39.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 May 2023 07:39:28 -0700 (PDT) Message-ID: <2490f7dd-9b6b-2865-4e44-37808b167c11@linaro.org> Date: Thu, 4 May 2023 16:39:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 2/8] dt-bindings: nvmem: rockchip-otp: Add compatible for RK3588 Content-Language: en-US To: Cristian Ciocaltea , Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Philipp Zabel , Sebastian Reichel , Shreeya Patel , Kever Yang , Finley Xiao Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230501084401.765169-1-cristian.ciocaltea@collabora.com> <20230501084401.765169-3-cristian.ciocaltea@collabora.com> <0678c24c-33ae-7e99-7bb6-d15dc5a7ed76@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/05/2023 16:14, Cristian Ciocaltea wrote: >>> + reset-names: >>> + items: >>> + - const: phy >>> + >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - rockchip,rk3588-otp >>> + then: >>> + properties: >>> + clocks: >>> + minItems: 4 >>> + maxItems: 4 >>> + clock-names: >>> + items: >>> + - const: otpc >>> + - const: apb >>> + - const: arb >>> + - const: phy >> >> Keep the same order of clocks as in older variants, so you can keep the >> list in top-level place and here only minItems: 4. >> >>> + resets: >>> + minItems: 1 >>> + maxItems: 3 >>> + reset-names: >>> + items: >>> + - const: otpc >> >> Shouldn't this be phy? > > It seems there is no reset for PHY, or at least I couldn't find any > reference in the RK3588 TRM, nor in the downstream driver implementation. OK, just to be sure that this is not the same reset as rk3308 just differently named in consumer. Best regards, Krzysztof