From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 107AF17985; Tue, 2 Jan 2024 23:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FP8lB1/k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61034C433C8; Tue, 2 Jan 2024 23:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704239232; bh=CZ2SLviVIOPK+w/RCmlYzrNM6ShsUO9iGFjmEfntgB0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=FP8lB1/kk6nY0Zr06Xne+pu4Q10+zqNFW7PN9ts5upxtbHxZpmExa3uDU4gsAXVJi 2gEgFVvquWlyL8SF2znEwyCuXWP28zgv7TceWoxRDiwRz1jr0RR1GMlbBYtC2zCI7C kYDyYA8Mgt0Drve6TyA2wLWel6hL2DjsD407tRdBOPloDGCaSBVl1coKRUzr+VPlvL 7EyTKnOgswXDWBfJjEZTsNmrRVRzwVyVWQdGZKPmpOYtmWVetAkFmEUaoJin57E+5d hVNNZCF/RwZ+njrDa7TFUfGG7/8D7F3BphXb3i/W6Ijopxd8cNN+IoZq9BTkhNUsYL kr1pRPVMNtjGA== Message-ID: <24c6c928b1714490360f534fe30c55df.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20231218-mbly-clk-v1-0-44ce54108f06@bootlin.com> <20231218-mbly-clk-v1-3-44ce54108f06@bootlin.com> Subject: Re: [PATCH 3/5] clk: eyeq5: add controller From: Stephen Boyd Cc: Vladimir Kondratiev , linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Tawfik Bayouk To: Conor Dooley , Gregory CLEMENT , Krzysztof Kozlowski , Michael Turquette , Rob Herring , Thomas Bogendoerfer , =?utf-8?q?Th=C3=A9o?= Lebrun Date: Tue, 02 Jan 2024 15:47:10 -0800 User-Agent: alot/0.10 Quoting Th=C3=A9o Lebrun (2023-12-27 08:30:20) >=20 > I went ahead with a V2, feeling it would be more productive to come up > with something and gather comments on concrete stuff. There were many > other things to address anyway. >=20 > I've addressed this point by declaring a dummy fixed-clock in the > devicetree that gets fed to the GIC timer. It is pretty much the same > thing as using `clock-frequency` which this specific clocksource uses > if `of_clk_get(node, 0)` fails. With the sent approach we have the > timer appear in the clock tree as a consumer. If the frequency is fixed then this seems fine to do always.