From: Andrew Lunn <andrew@lunn.ch>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Vinod Koul <vkoul@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 2/9] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems
Date: Wed, 10 Sep 2025 18:04:28 +0200 [thread overview]
Message-ID: <24cd127d-1be7-42f4-a2ec-697c5e7554db@lunn.ch> (raw)
In-Reply-To: <20250910-qcom-sa8255p-emac-v1-2-32a79cf1e668@linaro.org>
> + ethernet: ethernet@7a80000 {
> + compatible = "qcom,sa8255p-ethqos";
> + reg = <0x23040000 0x10000>,
> + <0x23056000 0x100>;
> + reg-names = "stmmaceth", "rgmii";
> +
> + iommus = <&apps_smmu 0x120 0x7>;
> +
> + interrupts = <GIC_SPI 946 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 782 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "sfty";
> +
> + dma-coherent;
> +
> + snps,tso;
> + snps,pbl = <32>;
> + rx-fifo-depth = <16384>;
> + tx-fifo-depth = <16384>;
> +
> + phy-handle = <&sgmii_phy1>;
> + phy-mode = "2500base-x";
Nitpicking: It is clearly not an SGMII PHY if it support
2500BaseX. You might want to give the node a better name.
> + snps,mtl-rx-config = <&mtl_rx_setup1>;
> + snps,mtl-tx-config = <&mtl_tx_setup1>;
> + snps,ps-speed = <1000>;
Since this MAC can do 2.5G, is 1000 correct here?
Andrew
next prev parent reply other threads:[~2025-09-10 16:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 8:07 [PATCH 0/9] net: stmmac: qcom-ethqos: add support for SCMI power domains Bartosz Golaszewski
2025-09-10 8:07 ` [PATCH 1/9] arm64: dts: qcom: sa8255: add ethernet nodes Bartosz Golaszewski
2025-09-10 8:07 ` [PATCH 2/9] dt-bindings: net: qcom: document the ethqos device for SCMI-based systems Bartosz Golaszewski
2025-09-10 13:38 ` Rob Herring (Arm)
2025-09-10 13:43 ` Bartosz Golaszewski
2025-09-10 14:36 ` Rob Herring
2025-09-10 14:42 ` Bartosz Golaszewski
2025-09-11 8:53 ` Konrad Dybcio
2025-09-11 9:22 ` Bartosz Golaszewski
2025-09-11 9:30 ` Konrad Dybcio
2025-09-10 16:04 ` Andrew Lunn [this message]
2025-09-11 8:58 ` Russell King (Oracle)
2025-09-10 8:07 ` [PATCH 3/9] net: stmmac: qcom-ethqos: use generic device properties Bartosz Golaszewski
2025-09-10 8:07 ` [PATCH 4/9] net: stmmac: qcom-ethqos: improve typing in devres callback Bartosz Golaszewski
2025-09-10 8:07 ` [PATCH 5/9] net: stmmac: qcom-ethqos: wrap emac driver data in additional structure Bartosz Golaszewski
2025-09-10 8:07 ` [PATCH 6/9] net: stmmac: qcom-ethqos: split power management fields into a separate structure Bartosz Golaszewski
2025-09-10 8:07 ` [PATCH 7/9] net: stmmac: qcom-ethqos: split power management context into a separate struct Bartosz Golaszewski
2025-09-10 8:07 ` [PATCH 8/9] net: stmmac: qcom-ethqos: define a callback for setting the serdes speed Bartosz Golaszewski
2025-09-10 8:07 ` [PATCH 9/9] net: stmmac: qcom-ethqos: add support for sa8255p Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24cd127d-1be7-42f4-a2ec-697c5e7554db@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox