From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Sachin Kamat' <sachin.kamat@linaro.org>,
linux-samsung-soc@vger.kernel.org
Cc: devicetree-discuss@lists.ozlabs.org
Subject: RE: [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen
Date: Sat, 08 Sep 2012 11:30:48 +0900 [thread overview]
Message-ID: <24d601cd8d69$f4f3e700$dedbb500$%kim@samsung.com> (raw)
In-Reply-To: <1347008770-11421-1-git-send-email-sachin.kamat@linaro.org>
Sachin Kamat wrote:
>
> Commit: f447ed8b31d (gpio: samsung: add flags specifier to
> device-tree binding) adds a flag to represent active low state
> for gpio line. Since gpio-keys on Origen board are active low,
> using this flag to represent the same.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
> ---
> arch/arm/boot/dts/exynos4210-origen.dts | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> b/arch/arm/boot/dts/exynos4210-origen.dts
> index 0c49caa..c37edf0 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -62,31 +62,31 @@
>
> up {
> label = "Up";
> - gpios = <&gpx2 0 0 0 2>;
> + gpios = <&gpx2 0 0 0x10000 2>;
> linux,code = <103>;
> };
>
> down {
> label = "Down";
> - gpios = <&gpx2 1 0 0 2>;
> + gpios = <&gpx2 1 0 0x10000 2>;
> linux,code = <108>;
> };
>
> back {
> label = "Back";
> - gpios = <&gpx1 7 0 0 2>;
> + gpios = <&gpx1 7 0 0x10000 2>;
> linux,code = <158>;
> };
>
> home {
> label = "Home";
> - gpios = <&gpx1 6 0 0 2>;
> + gpios = <&gpx1 6 0 0x10000 2>;
> linux,code = <102>;
> };
>
> menu {
> label = "Menu";
> - gpios = <&gpx1 5 0 0 2>;
> + gpios = <&gpx1 5 0 0x10000 2>;
> linux,code = <139>;
> };
> };
> --
> 1.7.4.1
Applied, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-09-08 2:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 9:06 [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen Sachin Kamat
2012-09-07 9:06 ` [PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen Sachin Kamat
2012-09-08 2:31 ` Kukjin Kim
2012-09-08 2:30 ` Kukjin Kim [this message]
2012-09-08 2:32 ` [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='24d601cd8d69$f4f3e700$dedbb500$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).