From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, robh+dt@kernel.org, pavel@ucw.cz
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 2/2] leds: lm3697: Introduce the lm3697 driver
Date: Fri, 17 Aug 2018 21:37:08 +0200 [thread overview]
Message-ID: <24e05753-8ec7-e1b0-8671-8443bc20130a@gmail.com> (raw)
In-Reply-To: <c751759a-d0c2-4ee7-2299-99d83538bdc4@ti.com>
Dan,
On 08/16/2018 10:44 PM, Dan Murphy wrote:
> Jacek
>
> On 08/16/2018 02:58 PM, Jacek Anaszewski wrote:
>> Dan,
>>
>> Thank you for the patch.
>>
>> I didn't review DT parsing details in v3, but now I've produced
>> diff between v3 and v4 to check what has changed.
>>
>> I'm quite surprised realizing that you're not validating
>> HVLED and control banks assignment, having in mind earlier
>> discussions and your concerns about numerous DT configurations
>> to check.
>>
>> Is it on purpose?
>>
>
> Yes. It was on purpose. After sleeping on it and going through the overall
> control to HVLED assignments I realized the user will know quite quickly
> that their configuration is messed up.
>
> The suggestions actually simplified the code quite nicely which I am happier to have
Ack. Thanks for the v5 - I'll let it sit on the lists for a week anyway,
until the merge window gets closed.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2018-08-17 19:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 17:20 [PATCH v4 1/2] dt-bindings: leds: Add bindings for lm3697 driver Dan Murphy
2018-08-16 17:20 ` [PATCH v4 2/2] leds: lm3697: Introduce the " Dan Murphy
2018-08-16 19:58 ` Jacek Anaszewski
2018-08-16 20:44 ` Dan Murphy
2018-08-17 19:37 ` Jacek Anaszewski [this message]
2018-08-17 19:55 ` Dan Murphy
2018-08-16 18:37 ` [PATCH v4 1/2] dt-bindings: leds: Add bindings for " Jacek Anaszewski
2018-08-16 18:43 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e05753-8ec7-e1b0-8671-8443bc20130a@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox