From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B75D27781B for ; Tue, 1 Jul 2025 15:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751383165; cv=none; b=GZTNgNX2+hAAjtWNi03mYC2NYDyOyMLNyy1QaUiKlX0dPotDBWvWpOSZ068UK9ALU8BB/ds2SMrNKpNwsn1QIi9DbJpGcZ5b/lsUB/kDMGBgxdQv7SO4gajYbGBi4sf2b+t4hBU3yFK8lmbsBgowT9SRX5cJcAuvy7naou7hLsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751383165; c=relaxed/simple; bh=t97TyzkipZFoGjqd9kPhcCuknyC/oH3E7SMZc9QKQZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tKJ/cSBbLhGe/i0iA+7gioLa8MHOK8aikEIVJ1zydg6Tl+ksfbW7XSOGSr/Fb/Ivylbq1FxNoy168GU+vlIg1ckOyKvyVw0gpH11XkZlaL2FUVgBsWGfUaSE9qAUhi3J8a6l0fHrFFfr9IDbFFmAtfGKtScisQsycm1FyRogu9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EOlQilcL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EOlQilcL" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5619pS7P028440 for ; Tue, 1 Jul 2025 15:19:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Cpr6mXrXqDKBVG3OQMvCgpkcRwa8yNEUsy9+Tt8IbAk=; b=EOlQilcL+QTJVHsK ZvO2fhkuUGlUAm9iDjBT6cp7XWiVkXb8X23LHTWc3sPYwKA/aiujbYP30rmKEQEn y+bApBXD1XW6f8S6/IQEQhZ0ZyttH1/DV4W2dePKT8txVqXlZMYr3f6Zkv+aVe6+ HtaZkmaTyYqjiUn9Kb80X9FKSbV5vVqxdufnOcVTdSei9g13YWgqIHpBDXRgbEZr mc4oKVKsBDmWpPQ8KSUWzFUYurpaLErYCj5ZyxmnVCGTyVCmADXYCR/lqNYN9c7N adxDIoGUhfJ0qoZVNcbYYsWGb/hTBihELp5kJJ51H1+gQO58u4HIuvpiLNVhqwnj SF/lgg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47j7bvsbgc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Jul 2025 15:19:23 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7d094e04aa4so174760385a.1 for ; Tue, 01 Jul 2025 08:19:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751383162; x=1751987962; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cpr6mXrXqDKBVG3OQMvCgpkcRwa8yNEUsy9+Tt8IbAk=; b=U4KTRqlAiA48mXud3eQ0+bBJ9iBED5XZHakqZwe0rGsNNGlUloh4DrU5MbuWb5IML/ Szs2ePZ3CovmXg6aJs8HqcYpOG5a2EkvceL/nFtXixeMgHtL7Tf/BYhUO9iKT75qQWdU 9qcajhgj8E8kc8VcSl86jg+B1S+x0uieYvM8B3LHp4Z+dhuxdoC6IH0kBNxs9LanXTri 7MSOSgyo0LWz64kl27yDmcKyB2LwOo+Gj7r7JubheEXHZ3KRWXU04s3h1GDvoeD1A+oR rjiP25bi4ASxznw53Y4PDIKSFNbZqHShX51zrTFvzKzqxcrQATt2bc/uUAhfhhTzm9Sz RdNA== X-Forwarded-Encrypted: i=1; AJvYcCXtA1bvtTmCJUJYT6jZ1qnMDfHDPYaR0s/T1ms2L8OGrUFlgcW9TKHk6rXQrWijpktsItrRpAH0hOr4@vger.kernel.org X-Gm-Message-State: AOJu0YzzyccW7J+Hdvgd/O+D1seF8irOiM4VxEKE+BNixmtlyEWbFjXW H5r/ywjb+EY0gtbTOQqoMi5cDmMajpVyOENzIqnhRL6MtY+jbdneQnoMbotIdpEqSxBsR5UqkJs jsQpJMSF/EU6HVY/CIUqdUVz4triq+Q72Br2clGQr2uMicATnapivy76c3CGcwOt5 X-Gm-Gg: ASbGncuMx292OHR1R9aOD8AQQxUQVmRdYS2kHrLxOhn1EUh6BIIEfo/XnRHUFqT6tUg YknJTOm9ejGTc1pabmIpeSu+OChLmbxol49Kc6sCw7JrPsWGxk4sUDjt0DKCdmwXAYDAz/D1Mk3 q7L6RVE2dp7ZQ+F3dT4YMeth0dO62GGIP1EYjQdoFAwjFFru8GyNI5xt8YXnwD7ul6A1Gj8BgR1 5YgQ8poTArjC/N5oCu/v+AWA11WjrX9kKw265bM765eXiaPFV8i44pT3uY4Mh1VLWQv2hHzPmhA vS5kucivPik+G13f4CmdU6y2OA22K5dbgcylGj9W/KIFvbDMijD/GeJ7Fz8i4eXWSrF2yuH8gVj 3Myu2DA0n X-Received: by 2002:a05:620a:29cf:b0:7d4:4a59:6e8f with SMTP id af79cd13be357-7d4677a1ef6mr168639085a.15.1751383161727; Tue, 01 Jul 2025 08:19:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVw9OkK18UsYMXtCQz0xp70vLQZThgvbIEpJsS6vmdbEaZ6WCWXVX9kJTqVkQwMWBZ3Tk8Fw== X-Received: by 2002:a05:620a:29cf:b0:7d4:4a59:6e8f with SMTP id af79cd13be357-7d4677a1ef6mr168635985a.15.1751383160972; Tue, 01 Jul 2025 08:19:20 -0700 (PDT) Received: from [192.168.1.114] (83.9.29.190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353ca20f3sm903250666b.175.2025.07.01.08.19.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 08:19:20 -0700 (PDT) Message-ID: <24e4241e-d8a1-41c7-b0f3-3ec01b4375ae@oss.qualcomm.com> Date: Tue, 1 Jul 2025 17:19:17 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] Add clock drivers for SM7635 To: Luca Weiss , Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250625-sm7635-clocks-v1-0-ca3120e3a80e@fairphone.com> <68056b4a-b1c3-401f-8720-8e0c3cda6249@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 4l9R033DRO_LOJAXWZOCNGiF8srDzb9l X-Authority-Analysis: v=2.4 cv=RJCzH5i+ c=1 sm=1 tr=0 ts=6863fc7b cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=fKQzr7EGRj+VoE0XNsDNvQ==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=6H0WHjuAAAAA:8 a=IgS4KiuvraTEoa23li4A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-ORIG-GUID: 4l9R033DRO_LOJAXWZOCNGiF8srDzb9l X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAxMDEwMiBTYWx0ZWRfX3O9UQ9TY9Rzo vOXyuBUxEC6PqnrV+Bx5KXAVR0A+jsg/I5EI/HXyVJrsC1Yao6H8Dg8uTfpF3GfcGj/5TYQjrwf HNJfLdsqD4JUQcAF/qTwCPVnvSZCFat1pX1+Y3DgUIbUS2J63b99syiyx9y/IRaGJ3/Dd77+raB RVManQJ8ddSDMwEQwKZYWzKgspmz/yKedbdJGjaLRdQic9kvBU6/IUWzvn+GZFcXamqx9KBJ+yr sL3LwA2WMX5TH2cLDuYjgb/ea42iBADjnnCpHNSGxYaCJarCe/dYjnTD/tZHpQaDl8R6DmvutKd Bz6Des3m6ZhUZyr0wXVFuKRB+bWnr+d1p85aOkkl8uZF3EHfxn8/NGAT76kC7K/Of0yf0uuhwmE zegDtPyInbCkwa01O/3YkqijMYhb5Tzrq+78V1IGF2pMV/mJRrSVnJS6+jq13MWdp85hLaE8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-01_02,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=789 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507010102 On 01-Jul-25 15:42, Luca Weiss wrote: > On Tue Jul 1, 2025 at 1:16 PM CEST, Dmitry Baryshkov wrote: >> On Mon, Jun 30, 2025 at 10:01:35AM +0200, Luca Weiss wrote: >>> Hi Konrad, >>> >>> On Fri Jun 27, 2025 at 5:14 PM CEST, Luca Weiss wrote: >>>> On Fri Jun 27, 2025 at 5:10 PM CEST, Konrad Dybcio wrote: >>>>> On 6/25/25 11:12 AM, Luca Weiss wrote: >>>>>> Document and add the clock drivers for GCC, CAMCC, DISPCC, GPUCC and >>>>>> VIDEOCC on the SM7635 SoC. >>>>>> >>>>>> Signed-off-by: Luca Weiss >>>>>> --- >>>>>> Luca Weiss (10): >>>>>> dt-bindings: clock: qcom: document the SM7635 Global Clock Controller >>>>>> clk: qcom: Add Global Clock controller (GCC) driver for SM7635 >>>>>> dt-bindings: clock: qcom: document the SM7635 Camera Clock Controller >>>>>> clk: qcom: Add Camera Clock controller (CAMCC) driver for SM7635 >>>>>> dt-bindings: clock: qcom: document the SM7635 Display Clock Controller >>>>>> clk: qcom: Add Display Clock controller (DISPCC) driver for SM7635 >>>>>> dt-bindings: clock: qcom: document the SM7635 GPU Clock Controller >>>>>> clk: qcom: Add Graphics Clock controller (GPUCC) driver for SM7635 >>>>>> dt-bindings: clock: qcom: document the SM7635 Video Clock Controller >>>>>> clk: qcom: Add Video Clock controller (VIDEOCC) driver for SM7635 >>>>> >>>>> We had a massive yak shaving patchset go in this season, please move >>>>> the magic settings in .probe to qcom_cc_driver_data {} >>>> >>>> Okay cool, I found them >>>> https://lore.kernel.org/linux-arm-msm/174970084192.547582.612305407582982706.b4-ty@kernel.org/ >>> >>> For camcc, gpucc and videocc it seems quite simple to follow these >>> changes. >>> >>> For dispcc I don't know what to do with this line. >>> >>> /* Enable clock gating for MDP clocks */ >>> regmap_update_bits(regmap, DISP_CC_MISC_CMD, 0x10, 0x10); >> >> Use clk_regs_configure() callback to set this bit. > > Got it, found an example on the lists. > >> >>> >>> Do I just keep the regmap references in this probe function and just >>> move the clk_lucid_ole_pll_configure & qcom_branch_set_clk_en to the >>> config struct? >>> >>> And similar for gcc, I can move the qcom_branch_set_clk_en calls there >>> but the qcom_cc_register_rcg_dfs needs to be kept. >> >> Would you mind extnding struct qcom_cc_desc with args to call >> qcom_cc_register_rcg_dfs() and call it from qcom_cc_really_probe()? > > Something like this? Not quite sure when (in what order) this should be > called, is that place fine? > > I'd include a patch then in the v2 of this series. > > diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c > index b3838d885db2..d53f290c6121 100644 > --- a/drivers/clk/qcom/common.c > +++ b/drivers/clk/qcom/common.c > @@ -390,6 +390,14 @@ int qcom_cc_really_probe(struct device *dev, > goto put_rpm; > } > > + if (desc->dfs_rcgs && desc->num_dfs_rcgs) { > + ret = qcom_cc_register_rcg_dfs(regmap, > + desc->dfs_rcgs, > + desc->num_dfs_rcgs); > + if (ret) > + goto put_rpm; > + } These were previously registered a bit earlier, but this should be good as well Konrad