From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fabio Estevam <festevam@gmail.com>, shawnguo@kernel.org
Cc: marex@denx.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] ARM: dts: imx6sx: Add LDB support
Date: Thu, 18 May 2023 09:21:59 +0200 [thread overview]
Message-ID: <24fbf72b-1e1c-1145-142b-518901869ea1@linaro.org> (raw)
In-Reply-To: <20230517210210.12183-1-festevam@gmail.com>
On 17/05/2023 23:02, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> i.MX6SX has an LVDS controller that is connected to the eLCDIF.
>
> Add support for it.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm/boot/dts/imx6sx.dtsi | 41 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 40 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 4233943a1cca..7a8a00d81666 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -843,8 +843,39 @@ iomuxc: pinctrl@20e0000 {
>
> gpr: iomuxc-gpr@20e4000 {
> compatible = "fsl,imx6sx-iomuxc-gpr",
> - "fsl,imx6q-iomuxc-gpr", "syscon";
> + "fsl,imx6q-iomuxc-gpr", "simple-bus", "syscon";
> + #address-cells = <1>;
> + #size-cells = <1>;
> reg = <0x020e4000 0x4000>;
It's a GPR, not a simple-bus. If you have here 'reg' then it is not
simple-bus.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-18 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 21:02 [PATCH] ARM: dts: imx6sx: Add LDB support Fabio Estevam
2023-05-17 23:15 ` Marek Vasut
2023-05-17 23:45 ` Fabio Estevam
2023-05-18 7:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24fbf72b-1e1c-1145-142b-518901869ea1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).