From: Alex Elder <elder@riscstar.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: manivannan.sadhasivam@oss.qualcomm.com,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] PCI/pwrctrl: tc9563: Fix parsing the integrated Ethernet MAC Endpoint node
Date: Tue, 28 Jul 2026 08:41:02 -0500 [thread overview]
Message-ID: <24fe82ef-ff0e-48ec-a6b6-c04d687e7359@riscstar.com> (raw)
In-Reply-To: <elrj4hfxzrtn2hfldhvk4ychlbmxcrksmttg45a6nw2h3gulso@4nk3lrgo5rvu>
On 7/28/26 8:38 AM, Manivannan Sadhasivam wrote:
>>> If so I think the DT binding could explain and possibly enforce
>>> that, but I won't insist on that...
>>>
>> It is being enforced in Patch 1.
>>
> Sorry, the current enforcement is only for PHY related properties like Tx
> Amplitude, DFE and N_FTS. I didn't limit ASPM properties in function 1 though.
> Doesn't seem to be strictly needed as no one would configure per-function ASPM
> settings in DT (mostly unlikely).
I think it's fine. You enforce what's needed at run time
regardless, right?
-Alex
next prev parent reply other threads:[~2026-07-28 13:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 8:59 [PATCH 0/6] PCI/pwrctrl: tc9563: Several fixes and improvements Manivannan Sadhasivam via B4 Relay
2026-07-25 8:59 ` [PATCH 1/6] dt-bindings: PCI: toshiba,tc9563: Restrict Tx Amplitude, DFE and N_FTS to USP, DSP1 and DSP2 Manivannan Sadhasivam via B4 Relay
2026-07-25 9:12 ` sashiko-bot
2026-07-27 15:59 ` Alex Elder
2026-07-28 13:09 ` Manivannan Sadhasivam
2026-07-25 8:59 ` [PATCH 2/6] PCI/pwrctrl: tc9563: Fix parsing the integrated Ethernet MAC Endpoint node Manivannan Sadhasivam via B4 Relay
2026-07-25 9:09 ` sashiko-bot
2026-07-27 14:17 ` Bartosz Golaszewski
2026-07-27 15:59 ` Alex Elder
2026-07-28 13:12 ` Manivannan Sadhasivam
2026-07-28 13:38 ` Manivannan Sadhasivam
2026-07-28 13:41 ` Alex Elder [this message]
2026-07-28 15:35 ` Manivannan Sadhasivam
2026-07-25 8:59 ` [PATCH 3/6] PCI/pwrctrl: tc9563: Power off only the external ports in tc9563_pwrctrl_disable_port() Manivannan Sadhasivam via B4 Relay
2026-07-25 9:07 ` sashiko-bot
2026-07-27 14:22 ` Bartosz Golaszewski
2026-07-27 15:59 ` Alex Elder
2026-07-25 8:59 ` [PATCH 4/6] PCI/pwrctrl: tc9563: Skip Tx amplitude and DFE tuning for DSP3 Manivannan Sadhasivam via B4 Relay
2026-07-25 9:12 ` sashiko-bot
2026-07-27 14:23 ` Bartosz Golaszewski
2026-07-27 15:59 ` Alex Elder
2026-07-28 13:25 ` Manivannan Sadhasivam
2026-07-28 13:34 ` Alex Elder
2026-07-28 16:04 ` Bjorn Helgaas
2026-07-25 8:59 ` [PATCH 5/6] PCI/pwrctrl: tc9563: Rename DSP3 to VDSP Manivannan Sadhasivam via B4 Relay
2026-07-25 9:11 ` sashiko-bot
2026-07-27 14:23 ` Bartosz Golaszewski
2026-07-27 15:59 ` Alex Elder
2026-07-25 8:59 ` [PATCH 6/6] PCI/pwrctrl: tc9563: Move Integrated MAC Endpoint out of 'tc9563_pwrctrl_ports' enum Manivannan Sadhasivam via B4 Relay
2026-07-25 9:04 ` sashiko-bot
2026-07-27 14:23 ` Bartosz Golaszewski
2026-07-27 15:59 ` Alex Elder
2026-07-27 16:29 ` [PATCH 0/6] PCI/pwrctrl: tc9563: Several fixes and improvements Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24fe82ef-ff0e-48ec-a6b6-c04d687e7359@riscstar.com \
--to=elder@riscstar.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox