Re: [PATCH v2 2/5] phy: qcom: Add Qualcomm PCIe PHY

Stanimir Varbanov
2015-05-04T15:24:10Z

On 05/04/2015 05:35 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Monday 04 May 2015 06:12 PM, Stanimir Varbanov wrote:
>> Add a PCIe PHY driver used by PCIe host controller driver
>> on Qualcomm SoCs like Snapdragon 805.
>>
>> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
>> ---
>> drivers/phy/Kconfig | 9 ++
>> drivers/phy/Makefile | 1 +
>> drivers/phy/phy-qcom-pcie.c | 291
>> +++++++++++++++++++++++++++++++++++++++++++
>
> Why do you need a new PHY driver for this? Why not use the existing QCOM
> PHY driver. I can see the registers used here in phy-qcom-ufs-qmp-14nm.h?

I agree that on first glance there are similarities, but I'm not sure
does the PHYs are the same IP blocks. Or at least they are different
revisions which have too many differences. So trying to combine them
will lead to more code than now.

Either way I will try to understand how many the differences are.

--
regards,
Stan