Re: [PATCH v2 5/5] ARM: qcom: Add Qualcomm APQ8084 SoC

Arnd Bergmann
2015-05-22T19:26:14Z

On Friday 22 May 2015 11:22:52 Stephen Boyd wrote:
> > diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
> > index 2256cd1..9cfebee 100644
> > --- a/arch/arm/mach-qcom/Kconfig
> > +++ b/arch/arm/mach-qcom/Kconfig
> > @@ -22,4 +22,11 @@ config ARCH_MSM8974
> > bool "Enable support for MSM8974"
> > select HAVE_ARM_ARCH_TIMER
> >
> > +config ARCH_APQ8084
> > + bool "Enable support for APQ8084"
> > + select HAVE_ARM_ARCH_TIMER
> > + select MIGHT_HAVE_PCI
> > + select PCI_DOMAINS if PCI
> > + select PCI_MSI if PCI
> > +
> >
>
> Can we move these PCI selects up to ARCH_QCOM directly? Let's try to
> avoid adding more SoC specific options under ARCH_QCOM.

I thought we already select 'MIGHT_HAVE_PCI' and 'PCI_DOMAINS' for
all ARMv7 platforms. If not, we probably should.

For PCI_MSI, I would leave that as user-selectable, there is no
need to enforce that as far as I can tell. If the driver needs
PCI_MSI support at compile-time, a dependency for that driver
would make sense.

Arnd