From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/2] mmc: omap_hsmmc: Add support for slot-name property in DT Date: Fri, 15 May 2015 23:19:44 +0200 Message-ID: <2523437.y90mKuWhc3@wuerfel> References: <1431724489-32359-1-git-send-email-pali.rohar@gmail.com> <1431724489-32359-2-git-send-email-pali.rohar@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1431724489-32359-2-git-send-email-pali.rohar@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Pali =?ISO-8859-1?Q?Roh=E1r?= Cc: =?ISO-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Ulf Hansson , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org List-Id: devicetree@vger.kernel.org On Friday 15 May 2015 23:14:48 Pali Roh=E1r wrote: > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hs= mmc.c > index 9df2b68..f6073dd 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1901,6 +1901,8 @@ static struct omap_hsmmc_platform_data *of_get_= hsmmc_pdata(struct device *dev) > if (of_find_property(np, "ti,needs-special-hs-handling", NULL= )) > pdata->features |=3D HSMMC_HAS_HSPE_SUPPORT; > =20 > + of_property_read_string(np, "slot-name", &pdata->name); > + > return pdata; > } >=20 This property needs to be documented in Documentation/devicetree/bindin= gs/mmc/mmc.txt and preferably the implementation moved into mmc_of_parse. We should not have an interface like this specific to one driver. Arnd