From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D1DCC433FE for ; Sun, 2 Oct 2022 08:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbiJBIDd (ORCPT ); Sun, 2 Oct 2022 04:03:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiJBIDa (ORCPT ); Sun, 2 Oct 2022 04:03:30 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 754DC50053 for ; Sun, 2 Oct 2022 01:03:29 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id p5so8843367ljc.13 for ; Sun, 02 Oct 2022 01:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=N3t/YAW8VeixJOi9b+cr0ysEOUoouz6B5QXiabNpm9k=; b=T+4B716cTi+f11ItCUFtaLFfpBnT1unBzw1xXr4Nb4r7r9GBknTI8hGZp3VbEUYDtX G9VczEoKRJXMJwsBAJm3fPrzyH4CVY/fauuj2s8xfIO7NRsRBQV+i+mhLIEcaIAIhzwe KCD5Ql7YgE/x3SlzZjmDc41TWoNByK2MOQcWx9SIyMDzwgrz3CWgvdHBCuq8pewzl+SM SYGodX5PsUtx2GU68A1X0rXoJYQ9KcgITsXCGCrN1yIMHM0srYUJvd24mgUDQvJYxafa JAKqnAowldSaU5xJhPja18mrwwpyRGKrHeNRyZ0ETQTi1LVrQYMuunsfSRz7BXpyEiHF IPeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=N3t/YAW8VeixJOi9b+cr0ysEOUoouz6B5QXiabNpm9k=; b=xRYfrEWU8MeS0Fwze2NBvEThCY6OYInabZuLjPM+AqEfpBP5MomA+6V3PsS78B7u5N eEZNdvfrNewvm0WiC7EDjMZRn2VLe3tdh9K8LlG+GcGEO8w/4AQcAxHjRvq3rjECt47u 9A6bNFbvLzwHQQ/jBlU0ccEv1ml7aILhYrpWzjIn8JBDglK2AhIGwa8qNlU3ga7jlWyz /d0zCtBTfm1quTVBxkKTu5IkvE2ZZpY2gANR5lMNszuuFcliO8Z61v7QhwD3pm9jN2in /WNhzuXDSyL8Fw92liMMNBt/E5RJl4NS+/stfD13wFbk2uEK3iq0n3FjkyShWCOODZsb Q6Iw== X-Gm-Message-State: ACrzQf3qELbUjy0hJi0hq3G+Gzkrs2z+Uln7rZ1oR6OD1DWB0rO2Xhfk QPz1ZxzPoYbwQowFbH32098Hjg== X-Google-Smtp-Source: AMsMyM762gfygKykIAizmzE81WFYB7jyFb8QiSOgtIw663bOpc3u1aBkPhjnB4MVlJTO3N54P8khwA== X-Received: by 2002:a2e:bcc6:0:b0:26d:c32d:72db with SMTP id z6-20020a2ebcc6000000b0026dc32d72dbmr2325903ljp.333.1664697807732; Sun, 02 Oct 2022 01:03:27 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id i8-20020a056512318800b00498f1eddad0sm1004343lfe.122.2022.10.02.01.03.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Oct 2022 01:03:26 -0700 (PDT) Message-ID: <25261abe-ad91-d648-f47e-b9236b35f06f@linaro.org> Date: Sun, 2 Oct 2022 10:03:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v4 2/2] dt-bindings: mips: brcm: convert Broadcom SoCs to schema Content-Language: en-US To: Sergio Paracuellos Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Krzysztof Kozlowski , Hauke Mehrtens , zajec5@gmail.com, Thomas Bogendoerfer , zhouyanjie@wanyeetech.com, "open list:MIPS" , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= References: <20221001043855.933528-1-sergio.paracuellos@gmail.com> <20221001043855.933528-3-sergio.paracuellos@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/10/2022 12:35, Sergio Paracuellos wrote: >> >>> + compatible: >>> + oneOf: >>> + - description: Boards with Broadcom bcm3368 SoC >>> + items: >>> + - const: brcm,bcm3368 >>> + >>> + - description: Boards with Broadcom bcm3384 SoC >>> + items: >>> + - const: brcm,bcm3384 >> >> I don't understand what did you want to achieve here. Either you >> document SoC or boards. If boards, where are the actual boards? If SoC, >> then why calling it boards, why making it oneOf? > > I agree with description should just say "Broadcom bcm3384 SoC", but I > don't understand what is wrong with oneOf here... If you document SoCs, this should be just an enum because it will take 20% of that lines. Much smaller, easier to read. In the same time (for documenting SoCs) all the descriptions are redundant. We know that this is "Broadcom bcm33843 SoC" because compatible is "brcm,bcm33843". > >> >> >>> + >>> + - description: Boards with Broadcom bcm33843 SoC >>> + items: >>> + - const: brcm,bcm33843 >>> + (...) > >> >>> + unevaluatedProperties: false >>> + >>> + properties: >>> + mips-hpt-frequency: >>> + description: This is common to all CPUs in the system so it lives >>> + under the "cpus" node. >> >> You need to describe what is this. Not where it lives. Because where it >> lives, we can easily see from the schema. > > I have just copied this from the previous documented bmips text file. I guess > writing the following will be better: > > properties: > mips-hpt-frequency: > description: MIPS counter high precision timer frequency. > This is common to all CPUs in the system so it lives > under the "cpus" node. > $ref: /schemas/types.yaml#/definitions/uint32 Much better, thanks. Best regards, Krzysztof