From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sibi Sankar Subject: Re: [PATCH v2 5/7] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Date: Tue, 18 Dec 2018 12:05:08 +0530 Message-ID: <2530f7f6019ba1ec950b4b27acba6993@codeaurora.org> References: <20181217100724.4593-1-sibis@codeaurora.org> <20181217100724.4593-5-sibis@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: Bjorn Andersson , Rob Herring , Andy Gross , David Brown , linux-arm-msm , "open list:ARM/QUALCOMM SUPPORT" , devicetree@vger.kernel.org, LKML , tsoni@codeaurora.org, clew@codeaurora.org, akdwived@codeaurora.org, Mark Rutland , linux-remoteproc@vger.kernel.org, Evan Green , Brian Norris , linux-soc-owner@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Doug, Thanks for the review :) On 2018-12-18 05:32, Doug Anderson wrote: > Hi, > > On Mon, Dec 17, 2018 at 2:08 AM Sibi Sankar > wrote: >> >> This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs. >> >> Signed-off-by: Sibi Sankar >> --- >> >> v2: >> * Fixed style changes >> * Added missing clocks in the dt-bindings >> * Split mss remoteproc node into a number of patches > > I know there was some off-list suggestion to split this into a number > of patches, but to actually make that useful to anyone we'd actually > need to _also_ post up patches to make the driver probe / work without > these power domains. ...and as per other discussions it's kinda > "lucky" that it happens to work without them and Bjorn wasn't > supportive of making this optional. > > So I'd actually fold patch 6 into patch 5 and focus on getting the > "aoss_qmp_pd" landed sooner rather than later. > I'll fold them in v3 > > Keeping the "shutdown-ack" as a separate patch makes sense though > since the bindings currently list that as "optional" and I guess > things work OK w/out it. > > > Once patch #6 is folded into patch #5 feel free to add my Reviewed-by > tag. okay -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.