[PATCH 0/5] arm64: dts: renesas: ulcb: Enable HDMI

[PATCH 0/5] arm64: dts: renesas: ulcb: Enable HDMI

[Vladimir Barinov]

Hello,

This patch series enables HDMI support for the H3 and M3-W based ULCB boards

This has the following dependency:
- [PATCH v2 series] R-Car Salvator-X M3-W: Enable DU support
- [PATCH] arm64: dts: renesas: ulcb: Enable I2C4
- [PATCH] clk: vc5: Add support for IDT VersaClock 5P49V5925

Vladimir Barinov (5):
[1/5] arm64: dts: renesas: ulcb: Add DU external dot clock sources
[2/5] arm64: dts: renesas: r8a7795-h3ulcb: Add DU external dot clocks
[3/5] arm64: dts: renesas: r8a7796-m3ulcb: Add DU external dot clocks
[4/5] arm64: dts: renesas: ulcb: Add HDMI output connector
[5/5] arm64: dts: renesas: ulcb: Enable HDMI output

---
This patchset is against the 'kernel/git/horms/renesas.git' repo.

 r8a7795-h3ulcb.dts |   14 ++++++++++++++
 r8a7796-m3ulcb.dts |   12 ++++++++++++
 ulcb.dtsi          |   42 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 68 insertions(+)

[PATCH 1/5] arm64: dts: renesas: ulcb: Add DU external dot clock sources

[Vladimir Barinov]

From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

The DU0/DU1/DU2/DU3 external dot clocks are generated by an I2C-controlled
programmable clock generator.

Clock generator is available on both the H3 and M3-W ULCB boards.
Add this to the ulcb.dtsi file.

Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index e402f16f..6f0a7ca 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -120,6 +120,12 @@
 		#clock-cells = <0>;
 		clock-frequency = <24576000>;
 	};
+
+	x23_clk: x23-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <25000000>;
+	};
 };
 
 &audio_clk_a {
@@ -193,6 +199,14 @@
 	status = "okay";
 
 	clock-frequency = <400000>;
+
+	versaclock5: clock-generator@6a {
+		compatible = "idt,5p49v5925";
+		reg = <0x6a>;
+		#clock-cells = <1>;
+		clocks = <&x23_clk>;
+		clock-names = "xin";
+	};
 };
 
 &i2c_dvfs {
-- 
1.9.1

Re: [PATCH 1/5] arm64: dts: renesas: ulcb: Add DU external dot clock sources

[Geert Uytterhoeven]

On Fri, Jul 7, 2017 at 4:36 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>
> The DU0/DU1/DU2/DU3 external dot clocks are generated by an I2C-controlled
> programmable clock generator.
>
> Clock generator is available on both the H3 and M3-W ULCB boards.
> Add this to the ulcb.dtsi file.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/5] arm64: dts: renesas: ulcb: Add DU external dot clock sources

[Simon Horman]

On Fri, Jul 07, 2017 at 05:36:59AM +0300, Vladimir Barinov wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> 
> The DU0/DU1/DU2/DU3 external dot clocks are generated by an I2C-controlled
> programmable clock generator.
> 
> Clock generator is available on both the H3 and M3-W ULCB boards.
> Add this to the ulcb.dtsi file.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> ---
>  arch/arm64/boot/dts/renesas/ulcb.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> index e402f16f..6f0a7ca 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> @@ -120,6 +120,12 @@
>  		#clock-cells = <0>;
>  		clock-frequency = <24576000>;
>  	};
> +
> +	x23_clk: x23-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <25000000>;
> +	};
>  };
>  
>  &audio_clk_a {
> @@ -193,6 +199,14 @@
>  	status = "okay";
>  
>  	clock-frequency = <400000>;
> +
> +	versaclock5: clock-generator@6a {
> +		compatible = "idt,5p49v5925";

Checkpatch tells me that "idt,5p49v5925" is undocumented (in v4.12-rc1).
Has this been addressed for v4.14? If not is there a plan to do so?

> +		reg = <0x6a>;
> +		#clock-cells = <1>;
> +		clocks = <&x23_clk>;
> +		clock-names = "xin";
> +	};
>  };
>  
>  &i2c_dvfs {
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] arm64: dts: renesas: ulcb: Add DU external dot clock sources

[Simon Horman]

On Mon, Jul 10, 2017 at 10:42:58AM +0200, Simon Horman wrote:
> On Fri, Jul 07, 2017 at 05:36:59AM +0300, Vladimir Barinov wrote:
> > From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> > 
> > The DU0/DU1/DU2/DU3 external dot clocks are generated by an I2C-controlled
> > programmable clock generator.
> > 
> > Clock generator is available on both the H3 and M3-W ULCB boards.
> > Add this to the ulcb.dtsi file.
> > 
> > Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> > ---
> >  arch/arm64/boot/dts/renesas/ulcb.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> > index e402f16f..6f0a7ca 100644
> > --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> > @@ -120,6 +120,12 @@
> >  		#clock-cells = <0>;
> >  		clock-frequency = <24576000>;
> >  	};
> > +
> > +	x23_clk: x23-clock {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <25000000>;
> > +	};
> >  };
> >  
> >  &audio_clk_a {
> > @@ -193,6 +199,14 @@
> >  	status = "okay";
> >  
> >  	clock-frequency = <400000>;
> > +
> > +	versaclock5: clock-generator@6a {
> > +		compatible = "idt,5p49v5925";
> 
> Checkpatch tells me that "idt,5p49v5925" is undocumented (in v4.12-rc1).
> Has this been addressed for v4.14? If not is there a plan to do so?

I now see "clk: vc5: Add support for IDT VersaClock 5P49V5925".
Sorry for the noise.

> 
> > +		reg = <0x6a>;
> > +		#clock-cells = <1>;
> > +		clocks = <&x23_clk>;
> > +		clock-names = "xin";
> > +	};
> >  };
> >  
> >  &i2c_dvfs {
> > -- 
> > 1.9.1
> > 
> 

[PATCH 2/5] arm64: dts: renesas: r8a7795-h3ulcb: Add DU external dot clocks

[Vladimir Barinov]

From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

The DU0/DU1/DU2/DU3 external dot clocks are provided by the programmable
Versaclock5 clock generator.

Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
index 0426f41..22645a9 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -40,3 +40,17 @@
 		reg = <0x7 0x00000000 0x0 0x40000000>;
 	};
 };
+
+&du {
+	clocks = <&cpg CPG_MOD 724>,
+		 <&cpg CPG_MOD 723>,
+		 <&cpg CPG_MOD 722>,
+		 <&cpg CPG_MOD 721>,
+		 <&cpg CPG_MOD 727>,
+		 <&versaclock5 1>,
+		 <&versaclock5 3>,
+		 <&versaclock5 4>,
+		 <&versaclock5 2>;
+	clock-names = "du.0", "du.1", "du.2", "du.3", "lvds.0",
+		      "dclkin.0", "dclkin.1", "dclkin.2", "dclkin.3";
+};
-- 
1.9.1

Re: [PATCH 2/5] arm64: dts: renesas: r8a7795-h3ulcb: Add DU external dot clocks

[Geert Uytterhoeven]

On Fri, Jul 7, 2017 at 4:37 AM, Vladimir Barinov
<vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
>
> The DU0/DU1/DU2/DU3 external dot clocks are provided by the programmable
> Versaclock5 clock generator.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/5] arm64: dts: renesas: r8a7796-m3ulcb: Add DU external dot clocks

[Vladimir Barinov]

From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

The DU0/DU1/DU2 external dot clocks are provided by the programmable
Versaclock5 clock generator.

Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
index 38b58b7..93446d1 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
@@ -30,3 +30,15 @@
 		reg = <0x6 0x00000000 0x0 0x40000000>;
 	};
 };
+
+&du {
+	clocks = <&cpg CPG_MOD 724>,
+		 <&cpg CPG_MOD 723>,
+		 <&cpg CPG_MOD 722>,
+		 <&cpg CPG_MOD 727>,
+		 <&versaclock5 1>,
+		 <&versaclock5 3>,
+		 <&versaclock5 2>;
+	clock-names = "du.0", "du.1", "du.2", "lvds.0",
+		      "dclkin.0", "dclkin.1", "dclkin.2";
+};
-- 
1.9.1

Re: [PATCH 3/5] arm64: dts: renesas: r8a7796-m3ulcb: Add DU external dot clocks

[Geert Uytterhoeven]

On Fri, Jul 7, 2017 at 4:37 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>
> The DU0/DU1/DU2 external dot clocks are provided by the programmable
> Versaclock5 clock generator.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 5/5] arm64: dts: renesas: ulcb: Enable HDMI output

[Vladimir Barinov]

From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

Enable the HDMI encoder for ULCB board and hook it up to the HDMI connector.

The HDMI encoder and connector are available on both the H3 and M3-W ULCB boards.
Add them to the ulcb.dtsi file.

Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
---
 arch/arm64/boot/dts/renesas/ulcb.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index fc5408d..89a8cb2 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -170,6 +170,23 @@
 	clock-frequency = <32768>;
 };
 
+&hdmi0 {
+	status = "okay";
+
+	ports {
+		port@1 {
+			reg = <1>;
+			rcar_dw_hdmi0_out: endpoint {
+				remote-endpoint = <&hdmi0_con>;
+			};
+		};
+	};
+};
+
+&hdmi0_con {
+	remote-endpoint = <&rcar_dw_hdmi0_out>;
+};
+
 &i2c2 {
 	pinctrl-0 = <&i2c2_pins>;
 	pinctrl-names = "default";
-- 
1.9.1

Re: [PATCH 5/5] arm64: dts: renesas: ulcb: Enable HDMI output

[Geert Uytterhoeven]

On Fri, Jul 7, 2017 at 4:37 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>
> Enable the HDMI encoder for ULCB board and hook it up to the HDMI connector.
>
> The HDMI encoder and connector are available on both the H3 and M3-W ULCB boards.
> Add them to the ulcb.dtsi file.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/5] arm64: dts: renesas: ulcb: Enable HDMI

[Simon Horman]

On Fri, Jul 07, 2017 at 05:36:16AM +0300, Vladimir Barinov wrote:
> Hello,
> 
> This patch series enables HDMI support for the H3 and M3-W based ULCB boards
> 
> This has the following dependency:
> - [PATCH v2 series] R-Car Salvator-X M3-W: Enable DU support
> - [PATCH] arm64: dts: renesas: ulcb: Enable I2C4
> - [PATCH] clk: vc5: Add support for IDT VersaClock 5P49V5925

I am holding off on applying these pending the first dependency above.

> 
> Vladimir Barinov (5):
> [1/5] arm64: dts: renesas: ulcb: Add DU external dot clock sources
> [2/5] arm64: dts: renesas: r8a7795-h3ulcb: Add DU external dot clocks
> [3/5] arm64: dts: renesas: r8a7796-m3ulcb: Add DU external dot clocks
> [4/5] arm64: dts: renesas: ulcb: Add HDMI output connector
> [5/5] arm64: dts: renesas: ulcb: Enable HDMI output
> 
> ---
> This patchset is against the 'kernel/git/horms/renesas.git' repo.
> 
>  r8a7795-h3ulcb.dts |   14 ++++++++++++++
>  r8a7796-m3ulcb.dts |   12 ++++++++++++
>  ulcb.dtsi          |   42 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 68 insertions(+)
> 

Re: [PATCH 0/5] arm64: dts: renesas: ulcb: Enable HDMI

[Laurent Pinchart]

H Vladimir,

On Friday 07 Jul 2017 05:36:16 Vladimir Barinov wrote:
> Hello,
> 
> This patch series enables HDMI support for the H3 and M3-W based ULCB boards
> 
> This has the following dependency:
> - [PATCH v2 series] R-Car Salvator-X M3-W: Enable DU support
> - [PATCH] arm64: dts: renesas: ulcb: Enable I2C4
> - [PATCH] clk: vc5: Add support for IDT VersaClock 5P49V5925
> 
> Vladimir Barinov (5):
> [1/5] arm64: dts: renesas: ulcb: Add DU external dot clock sources
> [2/5] arm64: dts: renesas: r8a7795-h3ulcb: Add DU external dot clocks
> [3/5] arm64: dts: renesas: r8a7796-m3ulcb: Add DU external dot clocks
> [4/5] arm64: dts: renesas: ulcb: Add HDMI output connector
> [5/5] arm64: dts: renesas: ulcb: Enable HDMI output

Thank you for the patches.

For patches 1/5, 2/5, 3/5 and 5/5,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Please see patch 4/5 for a small comment.

> ---
> This patchset is against the 'kernel/git/horms/renesas.git' repo.
> 
>  r8a7795-h3ulcb.dts |   14 ++++++++++++++
>  r8a7796-m3ulcb.dts |   12 ++++++++++++
>  ulcb.dtsi          |   42 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 68 insertions(+)

-- 
Regards,

Laurent Pinchart

[PATCH 4/5] arm64: dts: renesas: ulcb: Add HDMI output connector

[Vladimir Barinov]

From: Vladimir Barinov <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

The ULCB board has one HDMI output connector.

This connector is available on both the H3 and M3-W ULCB boards.
Add this to the ulcb.dtsi file.

Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/ulcb.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 6f0a7ca..fc5408d 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -34,6 +34,17 @@
 		clock-frequency = <11289600>;
 	};
 
+	hdmi0-out {
+		compatible = "hdmi-connector";
+		label = "HDMI0 OUT";
+		type = "a";
+
+		port {
+			hdmi0_con: endpoint {
+			};
+		};
+	};
+
 	keyboard {
 		compatible = "gpio-keys";
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/5] arm64: dts: renesas: ulcb: Add HDMI output connector

[Geert Uytterhoeven]

On Fri, Jul 7, 2017 at 4:37 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>
> The ULCB board has one HDMI output connector.
>
> This connector is available on both the H3 and M3-W ULCB boards.
> Add this to the ulcb.dtsi file.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 4/5] arm64: dts: renesas: ulcb: Add HDMI output connector

[Laurent Pinchart]

Hi Vladimir,

Thank you for the patch.

On Friday 07 Jul 2017 05:37:36 Vladimir Barinov wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> 
> The ULCB board has one HDMI output connector.
> 
> This connector is available on both the H3 and M3-W ULCB boards.
> Add this to the ulcb.dtsi file.
> 
> Signed-off-by: Vladimir Barinov
> <vladimir.barinov+renesas@cogentembedded.com> ---
>  arch/arm64/boot/dts/renesas/ulcb.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> b/arch/arm64/boot/dts/renesas/ulcb.dtsi index 6f0a7ca..fc5408d 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> @@ -34,6 +34,17 @@
>  		clock-frequency = <11289600>;
>  	};
> 
> +	hdmi0-out {
> +		compatible = "hdmi-connector";
> +		label = "HDMI0 OUT";

As far as I know there is no "HDMI0 OUT" label on the board or casing. You can 
remove the label property. Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +		type = "a";
> +
> +		port {
> +			hdmi0_con: endpoint {
> +			};
> +		};
> +	};
> +
>  	keyboard {
>  		compatible = "gpio-keys";

-- 
Regards,

Laurent Pinchart

Re: [PATCH 4/5] arm64: dts: renesas: ulcb: Add HDMI output connector

[Vladimir Barinov]

Hi Laurent,

Thank you for the review!

On 10.07.2017 16:09, Laurent Pinchart wrote:
> Hi Vladimir,
>
> Thank you for the patch.
>
> On Friday 07 Jul 2017 05:37:36 Vladimir Barinov wrote:
>> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>>
>> The ULCB board has one HDMI output connector.
>>
>> This connector is available on both the H3 and M3-W ULCB boards.
>> Add this to the ulcb.dtsi file.
>>
>> Signed-off-by: Vladimir Barinov
>> <vladimir.barinov+renesas@cogentembedded.com> ---
>>   arch/arm64/boot/dts/renesas/ulcb.dtsi | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi
>> b/arch/arm64/boot/dts/renesas/ulcb.dtsi index 6f0a7ca..fc5408d 100644
>> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
>> @@ -34,6 +34,17 @@
>>   		clock-frequency = <11289600>;
>>   	};
>>
>> +	hdmi0-out {
>> +		compatible = "hdmi-connector";
>> +		label = "HDMI0 OUT";
> As far as I know there is no "HDMI0 OUT" label on the board or casing. You can
> remove the label property. Apart from that,
I was thinking that this is a label on schematic.

ULCB has similar schematic label as first HDMI connector on Salvator-X  
"HDMI output(HDMI0)", hence I've just copied label name from Salvator-X 
file.

Right, there is no such name on ULCB pcb or plastic cover.

Is it okay If I resend only one patch with label field removed?

Regards,
Vladimir

Re: [PATCH 4/5] arm64: dts: renesas: ulcb: Add HDMI output connector

[Laurent Pinchart]

Hi Vladimir,

On Monday 10 Jul 2017 19:28:57 Vladimir Barinov wrote:
> On 10.07.2017 16:09, Laurent Pinchart wrote:
> > On Friday 07 Jul 2017 05:37:36 Vladimir Barinov wrote:
> >> From: Vladimir Barinov <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> >> 
> >> The ULCB board has one HDMI output connector.
> >> 
> >> This connector is available on both the H3 and M3-W ULCB boards.
> >> Add this to the ulcb.dtsi file.
> >> 
> >> Signed-off-by: Vladimir Barinov
> >> <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> ---
> >> 
> >>   arch/arm64/boot/dts/renesas/ulcb.dtsi | 11 +++++++++++
> >>   1 file changed, 11 insertions(+)
> >> 
> >> diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> >> b/arch/arm64/boot/dts/renesas/ulcb.dtsi index 6f0a7ca..fc5408d 100644
> >> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> >> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> >> @@ -34,6 +34,17 @@
> >> 
> >>   		clock-frequency = <11289600>;
> >>   	
> >>   	};
> >> 
> >> +	hdmi0-out {
> >> +		compatible = "hdmi-connector";
> >> +		label = "HDMI0 OUT";
> > 
> > As far as I know there is no "HDMI0 OUT" label on the board or casing. You
> > can remove the label property. Apart from that,
> 
> I was thinking that this is a label on schematic.
> 
> ULCB has similar schematic label as first HDMI connector on Salvator-X
> "HDMI output(HDMI0)", hence I've just copied label name from Salvator-X
> file.
> 
> Right, there is no such name on ULCB pcb or plastic cover.

Yes, that's the difference with the Salvator-X, where the plastic cover has a 
label.

> Is it okay If I resend only one patch with label field removed?

Sure.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/5] arm64: dts: renesas: ulcb: Enable HDMI

[Simon Horman]

On Fri, Jul 07, 2017 at 05:36:16AM +0300, Vladimir Barinov wrote:
> Hello,
> 
> This patch series enables HDMI support for the H3 and M3-W based ULCB boards
> 
> This has the following dependency:
> - [PATCH v2 series] R-Car Salvator-X M3-W: Enable DU support
> - [PATCH] arm64: dts: renesas: ulcb: Enable I2C4
> - [PATCH] clk: vc5: Add support for IDT VersaClock 5P49V5925
> 
> Vladimir Barinov (5):
> [1/5] arm64: dts: renesas: ulcb: Add DU external dot clock sources
> [2/5] arm64: dts: renesas: r8a7795-h3ulcb: Add DU external dot clocks
> [3/5] arm64: dts: renesas: r8a7796-m3ulcb: Add DU external dot clocks
> [4/5] arm64: dts: renesas: ulcb: Add HDMI output connector
> [5/5] arm64: dts: renesas: ulcb: Enable HDMI output

Thanks, I have applied v2 or 4/5 along with the remaining patches above for
v4.14.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html