From: Arnd Bergmann <arnd@arndb.de>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Patrick Lai <plai@codeaurora.org>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Kenneth Westfield <kwestfie@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF
Date: Fri, 22 May 2015 09:24:35 +0200 [thread overview]
Message-ID: <2534276.hIjFJK74Zh@wuerfel> (raw)
In-Reply-To: <1432245161-8990-1-git-send-email-srinivas.kandagatla@linaro.org>
On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote:
>
> config SND_SOC_LPASS_CPU
> tristate
> + depends on OF
> select REGMAP_MMIO
>
> config SND_SOC_LPASS_PLATFORM
> tristate
> + depends on OF
> select REGMAP_MMIO
>
> config SND_SOC_LPASS_IPQ806X
>
Could you instead make the drivers compile without OF being set?
I see that patch 7 and 8 introduces another two options doing
+config SND_SOC_LPASS_APQ8016
+ tristate
+ depends on SND_SOC_QCOM
+ select SND_SOC_LPASS_CPU
+ select SND_SOC_LPASS_PLATFORM
+
+config SND_SOC_APQ8016_SBC
+ tristate "SoC Audio support for APQ8016 SBC platforms"
+ depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
+ select SND_SOC_LPASS_APQ8016
+ help
so you get an obvious build failure here when SND_SOC_APQ8016_SBC
gets selected with COMPILE_TEST on a platform that does not support OF.
Arnd
next prev parent reply other threads:[~2015-05-22 7:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 21:52 [PATCH v3 00/10] ASoC: qcom: add support to apq8016 audio Srinivas Kandagatla
2015-05-21 21:52 ` [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF Srinivas Kandagatla
2015-05-22 7:24 ` Arnd Bergmann [this message]
2015-05-22 11:53 ` Srinivas Kandagatla
2015-05-22 13:21 ` Arnd Bergmann
2015-05-22 13:50 ` Srinivas Kandagatla
2015-05-22 13:15 ` Arnd Bergmann
2015-05-21 21:52 ` [PATCH v3 02/10] ASoC: qcom: support bitclk and osrclk per i2s port Srinivas Kandagatla
2015-05-22 12:27 ` Mark Brown
2015-05-21 21:52 ` [PATCH v3 03/10] ASoC: qcom: make osr clock optional Srinivas Kandagatla
2015-05-22 12:27 ` Mark Brown
2015-05-21 21:53 ` [PATCH v3 04/10] ASoC: qcom: add dma channel control offset to variant data Srinivas Kandagatla
2015-05-22 12:27 ` Mark Brown
2015-05-21 21:53 ` [PATCH v3 05/10] ASoC: qcom: Add ability to handle interrupts per dma channel Srinivas Kandagatla
2015-05-22 12:27 ` Mark Brown
2015-05-21 21:53 ` [PATCH v3 06/10] ASoC: qcom: add bit map to track static dma channel allocations Srinivas Kandagatla
2015-05-22 12:27 ` Mark Brown
2015-05-21 21:53 ` [PATCH v3 07/10] ASoC: qcom: Add apq8016 lpass driver support Srinivas Kandagatla
[not found] ` <1432245125-8939-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-21 21:53 ` [PATCH v3 08/10] ASoC: qcom: add apq8016 sound card support Srinivas Kandagatla
2015-05-21 21:53 ` [PATCH v3 09/10] ASoC: qcom: Document apq8016 bindings Srinivas Kandagatla
2015-05-22 12:33 ` Mark Brown
2015-05-21 21:53 ` [PATCH v3 10/10] ASoC: qcom: document apq8016 sbc machine driver bindings Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2534276.hIjFJK74Zh@wuerfel \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kwestfie@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox