From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver Date: Wed, 16 Jan 2013 08:44:54 +0100 Message-ID: <2542030.a14I18dBkO@flatron> References: <1358257112-19595-1-git-send-email-gautam.vivek@samsung.com> <1358257112-19595-3-git-send-email-gautam.vivek@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1358257112-19595-3-git-send-email-gautam.vivek@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Vivek Gautam Cc: linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, kgene.kim@samsung.com, grant.likely@secretlab.ca, dianders@chromium.org, jg1.han@samsung.com List-Id: devicetree@vger.kernel.org Hi Vivek, On Tuesday 15 of January 2013 19:08:30 Vivek Gautam wrote: > Adding OHCI device tree node for Exynos5250 along with > the device base address. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > Acked-by: Grant Likely > --- > .../devicetree/bindings/usb/exynos-usb.txt | 15 > +++++++++++++++ arch/arm/boot/dts/exynos5250.dtsi | > 6 ++++++ 2 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt > b/Documentation/devicetree/bindings/usb/exynos-usb.txt index > e8bbb47..f66fcdd 100644 > --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt > +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt > @@ -23,3 +23,18 @@ Example: > interrupts = <0 71 0>; > samsung,vbus-gpio = <&gpx2 6 1 3 3>; > }; > + > +OHCI > +Required properties: > + - compatible: should be "samsung,exynos4210-ohci" for USB 2.0 > + OHCI companion controller in host mode. > + - reg: physical base address of the controller and length of memory > mapped + region. > + - interrupts: interrupt number to the cpu. > + > +Example: > + usb@12120000 { > + compatible = "samsung,exynos4210-ohci"; > + reg = <0x12120000 0x100>; > + interrupts = <0 71 0>; > + }; > diff --git a/arch/arm/boot/dts/exynos5250.dtsi > b/arch/arm/boot/dts/exynos5250.dtsi index 2cbe53e..ebb0907 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -281,6 +281,12 @@ > interrupts = <0 71 0>; > }; > > + usb@12120000 { > + compatible = "samsung,exynos4210-ohci"; > + reg = <0x12120000 0x100>; > + interrupts = <0 71 0>; For Samsung platforms we decided per board enabling of nodes and so this node should also contain: status = "disabled"; while in dts file of board using ohci there would be an overriding entry: usb@12120000 { status = "okay"; }; I know that Exynos5250 has not been yet converted into this convention, but using it when adding new devices will simplify the process. Best regards, Tomasz