From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 057D43033E6; Tue, 1 Sep 2026 13:55:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788270957; cv=none; b=Mt5yomniK06b3upPM2M94Foy0OzVfUPdlYIrHG/KzmMf52JGPlFRP31oNOJX9lpSRsT8rm3NhJL15GJ8oyEGYb8GKfF2fLcCbtrnYBiJXQmA59P5IkAhoc030JNnUqvuwleS0txlgnWL+pPEcqA+Repp8d7FYma1uRfnL6jeFLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788270957; c=relaxed/simple; bh=bz4t76tc9Sqh4peXj1ABtUMfrElA2dA8HE+vh8PhAtA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MvGDhdr1b4awC6gEX5Kt7sesZZBqJioXCNOiw9HkjNquK3kYQ4x4zZV9GTUhDL1aqtRj6VByh0H2DddMMEi8s5SiQnSHYnRlHnFBJL7Do3n4Z0y7AOkGyYzT7ubZS5UULsuF6RFC+hhaIs/8UMvzKV0J/RSuUEB7M2jSinqwQ3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from [141.14.220.42] (g42.guest.molgen.mpg.de [141.14.220.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 2AB444C2C37F01; Tue, 01 Sep 2026 15:55:41 +0200 (CEST) Message-ID: <254803cb-7b5c-41c6-84bb-0de7fe7e6f12@molgen.mpg.de> Date: Tue, 1 Sep 2026 15:55:38 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] Bluetooth: btbcm: Add Synaptics 4384 chip support To: Andy Chang Cc: Marcel Holtmann , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org References: <20260901023300.1382808-2-andy.chang@synaptics.corp-partner.google.com> <20260901085702.1515378-1-andy.chang@synaptics.corp-partner.google.com> <20260901085702.1515378-3-andy.chang@synaptics.corp-partner.google.com> Content-Language: en-US From: Paul Menzel In-Reply-To: <20260901085702.1515378-3-andy.chang@synaptics.corp-partner.google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear Andy, Thank you for your patch. Same comments as in *PATCH v3 1/2*. Am 01.09.26 um 10:57 schrieb Andy Chang: > Add support for the Synaptics 4384 Bluetooth controller > by adding the corresponding chip IDs. > > Tested on the VIM3 platform. Verified that the controller initializes > successfully and that firmware loading and basic Bluetooth operation > work as expected. > > The VIM3 is a Khadas single-board computer that I used as the host > platform for testing the BCM4384 Bluetooth controller. Should you resend, please paste the new Linux log message into the commit message, as most people don’t have the hardware for testing. > Signed-off-by: Andy Chang > --- > drivers/bluetooth/btbcm.c | 6 +++++- > drivers/bluetooth/hci_bcm.c | 1 + > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c > index 463d59890bef..63c4c788d9c4 100644 > --- a/drivers/bluetooth/btbcm.c > +++ b/drivers/bluetooth/btbcm.c > @@ -31,6 +31,7 @@ > #define BDADDR_BCM4334B0 (&(bdaddr_t) {{0x00, 0x00, 0x00, 0xb0, 0x34, 0x43}}) > #define BDADDR_BCM4345C5 (&(bdaddr_t) {{0xac, 0x1f, 0x00, 0xc5, 0x45, 0x43}}) > #define BDADDR_BCM43341B (&(bdaddr_t) {{0xac, 0x1f, 0x00, 0x1b, 0x34, 0x43}}) > +#define BDADDR_BCM4384B0 (&(bdaddr_t) {{0x93, 0x76, 0x00, 0xb0, 0x84, 0x43}}) > > #define BCM_FW_NAME_LEN 64 > #define BCM_FW_NAME_COUNT_MAX 4 > @@ -130,7 +131,8 @@ int btbcm_check_bdaddr(struct hci_dev *hdev) > !bacmp(&bda->bdaddr, BDADDR_BCM4345C5) || > !bacmp(&bda->bdaddr, BDADDR_BCM43430A0) || > !bacmp(&bda->bdaddr, BDADDR_BCM43430A1) || > - !bacmp(&bda->bdaddr, BDADDR_BCM43341B)) { > + !bacmp(&bda->bdaddr, BDADDR_BCM43341B) || > + !bacmp(&bda->bdaddr, BDADDR_BCM4384B0)) { > /* Try falling back to BDADDR EFI variable */ > if (btbcm_set_bdaddr_from_efi(hdev) != 0) { > bt_dev_info(hdev, "BCM: Using default device address (%pMR)", > @@ -514,6 +516,8 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = { > { 0x4106, "BCM4335A0" }, /* 002.001.006 */ > { 0x410c, "BCM43430B0" }, /* 002.001.012 */ > { 0x2119, "BCM4373A0" }, /* 001.001.025 */ > + { 0x2128, "BCM4384A0" }, /* 001.001.040 */ > + { 0x4119, "BCM4384B0" }, /* 002.001.025 */ > { } > }; > > diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c > index 9a103db7e355..e70b9f3fd968 100644 > --- a/drivers/bluetooth/hci_bcm.c > +++ b/drivers/bluetooth/hci_bcm.c > @@ -1593,6 +1593,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = { > { .compatible = "brcm,bcm4349-bt", .data = &bcm43438_device_data }, > { .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data }, > { .compatible = "brcm,bcm4335a0" }, > + { .compatible = "brcm,bcm4384-bt" }, > { .compatible = "cypress,cyw4373a0-bt", .data = &cyw4373a0_device_data }, > { .compatible = "infineon,cyw55572-bt", .data = &cyw55572_device_data }, > { }, Reviewed-by: Paul Menzel Kind regards, Paul