devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>, neil.armstrong@linaro.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	jagan@amarulasolutions.com, inki.dae@samsung.com,
	Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml
Date: Mon, 3 Apr 2023 18:10:00 +0200	[thread overview]
Message-ID: <254e965e-3ef5-7628-d40b-eedf4cb25a0c@denx.de> (raw)
In-Reply-To: <20230331195746.114840-1-festevam@gmail.com>

On 3/31/23 21:57, Fabio Estevam wrote:

[...]

> +properties:
> +  compatible:
> +    enum:
> +      - samsung,exynos3250-mipi-dsi
> +      - samsung,exynos4210-mipi-dsi
> +      - samsung,exynos5410-mipi-dsi
> +      - samsung,exynos5422-mipi-dsi
> +      - samsung,exynos5433-mipi-dsi
> +      - fsl,imx8mm-mipi-dsim
> +      - fsl,imx8mp-mipi-dsim

Can you handle "fsl,imx8mn-mipi-dsim", "fsl,imx8mm-mipi-dsim" here too ?
The MX8MN DSIM bridge is compatible with MX8MM DSIM bridge. The change 
should be something like:

diff --git 
a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml 
b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
index 2698752dc6edf..6a30194d3347e 100644
--- 
a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
+++ 
b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
@@ -16,14 +16,18 @@ description: |

  properties:
    compatible:
-    enum:
-      - samsung,exynos3250-mipi-dsi
-      - samsung,exynos4210-mipi-dsi
-      - samsung,exynos5410-mipi-dsi
-      - samsung,exynos5422-mipi-dsi
-      - samsung,exynos5433-mipi-dsi
-      - fsl,imx8mm-mipi-dsim
-      - fsl,imx8mp-mipi-dsim
+    oneOf:
+      - enum:
+          - samsung,exynos3250-mipi-dsi
+          - samsung,exynos4210-mipi-dsi
+          - samsung,exynos5410-mipi-dsi
+          - samsung,exynos5422-mipi-dsi
+          - samsung,exynos5433-mipi-dsi
+          - fsl,imx8mm-mipi-dsim
+          - fsl,imx8mp-mipi-dsim
+      - items:
+          - const: fsl,imx8mn-mipi-dsim
+          - const: fsl,imx8mm-mipi-dsim

    reg:
      maxItems: 1

  parent reply	other threads:[~2023-04-03 16:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 19:57 [PATCH] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml Fabio Estevam
2023-04-01 11:11 ` Jagan Teki
2023-04-02 17:52 ` Marek Vasut
2023-04-03 12:49 ` Krzysztof Kozlowski
2023-04-03 16:10 ` Marek Vasut [this message]
2023-04-03 16:11 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=254e965e-3ef5-7628-d40b-eedf4cb25a0c@denx.de \
    --to=marex@denx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=inki.dae@samsung.com \
    --cc=jagan@amarulasolutions.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).