From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE751C4167B for ; Tue, 29 Nov 2022 08:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230118AbiK2ICJ (ORCPT ); Tue, 29 Nov 2022 03:02:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbiK2IBt (ORCPT ); Tue, 29 Nov 2022 03:01:49 -0500 Received: from sender4-op-o14.zoho.com (sender4-op-o14.zoho.com [136.143.188.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12ED01DF1E; Tue, 29 Nov 2022 00:01:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669708863; cv=none; d=zohomail.com; s=zohoarc; b=Mt8zflQluXrktvTMy1+7/wqUymDJuNvxcCt9uUvUKw10sGTDK0MmA+82aNr+WwHy9LSPljlTOlsgEk2qQ+EFoOjz+teCuYjgTlWnrXhLgNnE8tc4Ud3W0t3AncJ7vXMDugqp76mqGhM2nALe85m0kzUnLVwq/PXuz8TkjBabTtQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669708863; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=SFqgWmLTPu6Efm5uqI8QHWhAPlyBeMn1zR3+/c+MyV4=; b=XrJLcU4oGZ6bewSlAoGFPefar0lVihXpG2DX7/j5p01eou8CQKfswf1NEdKjTW33pEsGgoBnOvPF1JHhQyILjBt9OXmPxSquYOZ1IP3sOuLQzdbv22MSDzh9ZRPSZDdndb8TawlE4FdHYC54PhKac4RuD6J1t+Fne3mLQOnEN/w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1669708863; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=SFqgWmLTPu6Efm5uqI8QHWhAPlyBeMn1zR3+/c+MyV4=; b=NzMQ77o6X9I3VrDmPEHUQN1icfGztgC2EGc0z02LnLq1jMb3ZETBFPplSN2gf4gy SoLMOp5SVhwl/Ioye3A0wg2ZZtIwr++hN1PXGbga2DP1ttKOv/OC9+9KCKhrBTR8ucQ zyYoL7Sc7+oh6Um8H7311lXEphsGe+F/tIg5zvrU= Received: from [10.10.10.3] (85.117.236.245 [85.117.236.245]) by mx.zohomail.com with SMTPS id 1669708862210987.5702214730692; Tue, 29 Nov 2022 00:01:02 -0800 (PST) Message-ID: <25533005-60bf-a9bb-d6a0-d14e1804291a@arinc9.com> Date: Tue, 29 Nov 2022 11:00:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 net-next 06/10] dt-bindings: net: dsa: mediatek,mt7530: fix port description location To: Colin Foster Cc: linux-renesas-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, John Crispin , Alexandre Belloni , Claudiu Manoil , Marek Vasut , Sean Wang , DENG Qingfang , Landen Chao , Vivien Didelot , =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , =?UTF-8?Q?Alvin_=c5=a0ipraga?= , Linus Walleij , UNGLinuxDriver@microchip.com, Woojung Huh , Matthias Brugger , Kurt Kanzenbach , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , George McCollister , Rob Herring References: <20221127224734.885526-1-colin.foster@in-advantage.com> <20221127224734.885526-7-colin.foster@in-advantage.com> <08784493-7e85-9224-acfa-9a87cbd325e7@arinc9.com> Content-Language: en-US From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hey Colin, On 29.11.2022 09:32, Colin Foster wrote: > Hi Arınç, > > On Mon, Nov 28, 2022 at 11:28:31AM +0300, Arınç ÜNAL wrote: >> On 28.11.2022 01:47, Colin Foster wrote: >>> The description property was located where it applies to every port, not >>> just ports 5 or 6 (CPU ports). Fix this description. >> >> I'm not sure I understand. The description for reg does apply to every port. >> Both CPU ports and user ports are described. This patch moves the >> description to under CPU ports only. > > You're right. I misinterpreted what Rob suggested, so the commit message > isn't correct. I see now that reg applies to every port, but is only > restricted for CPU ports (if: required: [ ethernet ]). I'll clean this > message up. > >> >>> >>> Suggested-by: Rob Herring >>> Signed-off-by: Colin Foster >>> --- >>> >>> v2 -> v3 >>> * New patch. >>> >>> --- >>> .../bindings/net/dsa/mediatek,mt7530.yaml | 14 +++----------- >>> 1 file changed, 3 insertions(+), 11 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>> index 7df4ea1901ce..415e6c40787e 100644 >>> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >>> @@ -156,17 +156,6 @@ patternProperties: >>> patternProperties: >>> "^(ethernet-)?port@[0-9]+$": >>> - type: object >>> - description: Ethernet switch ports >>> - >>> - unevaluatedProperties: false >>> - >> >> Would be nice to mention these being removed on the patch log. Or remove >> them while doing ("dt-bindings: net: dsa: utilize base definitions for >> standard dsa switches"). > > Agreed. My gut is telling me this wants to be in a separate patch from > the generic DSA base definitions patch... but I can't say why for > certain. I'll plan to move these to the patch you suggest and add a comment If I understand correctly, with ("dt-bindings: net: dsa: utilize base definitions for standard dsa switches"), these properties are now defined on dsa.yaml#/$defs/base and no longer needed to be defined here since mediatek,mt7530.yaml was also made to refer to it. It'd make sense to remove these properties there as there's continuity. > in there about how the type, description, and unevaluatedProperties of > mediatek,mt7530 is no longer needed as a result? Keep this patch as more > of a "restrict custom port description to CPU ports only" patch? I'd say get rid of this patch and do above. Trust your gut though. ;P Arınç