From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2] ARM: omap3: beagleboard-xm: dt: Add ethernet to the device tree Date: Thu, 05 Jan 2017 18:48:38 +0200 Message-ID: <2557392.58vudoaMIY@avalon> References: <1480713097-5931-1-git-send-email-laurent.pinchart@ideasonboard.com> <20170105163928.GD4310@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20170105163928.GD4310-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tony Lindgren Cc: Rob Herring , linux-omap , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , =?ISO-8859-1?Q?Beno=EEt?= Cousson List-Id: devicetree@vger.kernel.org Hello, On Thursday 05 Jan 2017 08:39:29 Tony Lindgren wrote: > * Rob Herring [170105 08:28]: > > On Fri, Dec 2, 2016 at 3:11 PM, Laurent Pinchart wrote: > >> The Beagleboard-xM has a LAN9514 USB hub and ethernet controller, > >> connected to port 2 of the OMAP EHCI controller. The board however has > >> no EEPROM to store the ethernet MAC address, which is programmed by the > >> boot loader. > >> > >> To allow Linux to use the same MAC address as the boot loader (or for > >> that matter any fixed MAC address), we need a node in the device tree > >> for the ethernet controller that the boot loader can update at runtime > >> with a local-mac-address property. Add it, along with an alias for the > >> ethernet controller to let the boot loader locate it easily. > >> > >> Signed-off-by: Laurent Pinchart > >> --- > >> Changes since v1: > >> > >> - Renamed usb2 DT node to hub > >> --- > >> > >> arch/arm/boot/dts/omap3-beagle-xm.dts | 16 ++++++++++++++++ > >> 1 file changed, 16 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts > >> b/arch/arm/boot/dts/omap3-beagle-xm.dts index > >> 85e297ed0ea1..673cee2234b2 100644 > >> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > >> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > >> @@ -27,6 +27,7 @@ > >> aliases { > >> display0 = &dvi0; > >> display1 = &tv0; > >> + ethernet = ðernet; > > > > Sorry, just noticed this, but this should be dropped. It's not used > > nor do we want an alias here. > > OK, will update locally as I have not pushed out yet. The ethernet alias is used by U-Boot to locate the ethernet controller and update the MAC address. > > P.S. The display ones are questionable, too. Only OMAP has them and > > per platform alias names is not something we want. > > OK. What about the mmc ones? Otherwise the MMC devices keep moving > around depending on the kernel version.. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html