From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCHv1 01/11] dt-bindings: power: supply: adc-battery: add binding
Date: Sun, 12 Mar 2023 12:29:09 +0100 [thread overview]
Message-ID: <255e857e-c4a4-c90a-f8bc-8c20b02f0839@linaro.org> (raw)
In-Reply-To: <20230309225041.477440-2-sre@kernel.org>
On 09/03/2023 23:50, Sebastian Reichel wrote:
> Add binding for a battery that is only monitored via ADC
> channels and simple status GPIOs.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
Thank you for your patch. There is something to discuss/improve.
> +
> +maintainers:
> + - Sebastian Reichel <sre@kernel.org>
> +
> +description: |
Don't need '|'.
> + Basic Battery, which only reports (in circuit) voltage and optionally
> + current via an ADC channel.
> +
> +allOf:
> + - $ref: power-supply.yaml#
> +
> +properties:
> + compatible:
> + const: adc-battery
> +
> + charged-gpios:
> + description:
> + GPIO which signals that the battery is fully charged.
> + maxItems: 1
> +
> + io-channels:
> + minItems: 1
> + maxItems: 3
> +
> + io-channel-names:
Simpler:
minItems: 1
items:
- const: voltage
- enum: [ current, power ]
- const: power
> + oneOf:
> + - const: voltage
> + - items:
> + - const: voltage
> + - enum:
> + - current
> + - power
> + - items:
> + - const: voltage
> + - const: current
> + - const: power
> +
What about temperature? For max17040 this was recently proposed and I
wonder whether it is desirable.
https://lore.kernel.org/all/74ba115e-9838-4983-7b93-188a8260dd8a@linaro.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-12 11:30 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 22:50 [PATCHv1 00/11] Add DT support for generic ADC battery Sebastian Reichel
2023-03-09 22:50 ` [PATCHv1 01/11] dt-bindings: power: supply: adc-battery: add binding Sebastian Reichel
2023-03-10 8:14 ` Linus Walleij
2023-03-11 17:54 ` Sebastian Reichel
2023-03-12 17:07 ` [PATCHv1 02/11] power: supply: core: auto-exposure of simple-battery data Sebastian Reichel
2023-03-12 22:36 ` [PATCH] power: supply: charger-manager: Use of_property_read_bool() for boolean properties Sebastian Reichel
2023-03-13 23:17 ` [PATCHv1 04/11] power: supply: generic-adc-battery: fix unit scaling Sebastian Reichel
2023-03-14 8:14 ` Linus Walleij
2023-03-12 11:29 ` Krzysztof Kozlowski [this message]
2023-03-13 6:13 ` [PATCHv1 01/11] dt-bindings: power: supply: adc-battery: add binding Matti Vaittinen
2023-03-09 22:50 ` [PATCHv1 02/11] power: supply: core: auto-exposure of simple-battery data Sebastian Reichel
2023-03-10 1:36 ` kernel test robot
2023-03-10 5:10 ` kernel test robot
2023-03-10 8:20 ` Linus Walleij
2023-03-13 6:45 ` Matti Vaittinen
2023-03-09 22:50 ` [PATCHv1 03/11] power: supply: generic-adc-battery: convert to managed resources Sebastian Reichel
2023-03-10 8:21 ` Linus Walleij
2023-03-13 7:14 ` Matti Vaittinen
2023-03-09 22:50 ` [PATCHv1 04/11] power: supply: generic-adc-battery: fix unit scaling Sebastian Reichel
2023-03-10 8:23 ` Linus Walleij
2023-03-13 7:52 ` Matti Vaittinen
2023-03-09 22:50 ` [PATCHv1 05/11] power: supply: generic-adc-battery: drop jitter delay support Sebastian Reichel
2023-03-10 8:24 ` Linus Walleij
2023-03-09 22:50 ` [PATCHv1 06/11] power: supply: generic-adc-battery: drop charge now support Sebastian Reichel
2023-03-10 8:29 ` Linus Walleij
2023-03-13 7:49 ` Matti Vaittinen
2023-03-13 8:33 ` Linus Walleij
2023-03-09 22:50 ` [PATCHv1 07/11] power: supply: generic-adc-battery: drop memory alloc error message Sebastian Reichel
2023-03-10 8:29 ` Linus Walleij
2023-03-13 7:50 ` Matti Vaittinen
2023-03-09 22:50 ` [PATCHv1 08/11] power: supply: generic-adc-battery: use simple-battery API Sebastian Reichel
2023-03-10 8:30 ` Linus Walleij
2023-03-09 22:50 ` [PATCHv1 09/11] power: supply: generic-adc-battery: simplify read_channel logic Sebastian Reichel
2023-03-10 8:31 ` Linus Walleij
2023-03-13 8:19 ` Matti Vaittinen
2023-03-09 22:50 ` [PATCHv1 10/11] power: supply: generic-adc-battery: add DT support Sebastian Reichel
2023-03-10 8:32 ` Linus Walleij
2023-03-13 8:22 ` Matti Vaittinen
2023-03-09 22:50 ` [PATCHv1 11/11] power: supply: generic-adc-battery: update copyright info Sebastian Reichel
2023-03-10 8:33 ` Linus Walleij
2023-03-13 8:25 ` Matti Vaittinen
-- strict thread matches above, loose matches on Subject: below --
2023-03-10 14:47 [PATCH] power: supply: charger-manager: Use of_property_read_bool() for boolean properties Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=255e857e-c4a4-c90a-f8bc-8c20b02f0839@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).