From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 355B31B47DE; Thu, 20 Jun 2024 18:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718908970; cv=none; b=BiG3FcEI8LcgjYFUZMoOb2K3l0UcQblZSOOimHAh2TwJ2hOptXzYHlo/t/ZtOXGGMDU7DXCk7/VDjjus6qtfx3/x4SfKsEDrXvZQFH0ydj93IHZiSP/cRzNfjPoeI/AYxcIhzvXXjkGK9f9MubSJDXI0WbIJKp1m6tXx1PgwZUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718908970; c=relaxed/simple; bh=LvnaCPxKoIZfQ4R88XqAC/V17BVWq6QoYfODJKaC0tk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F08d//MeDB29Cd43TyBOItD4OrcHdeGoEb9PmBUhfEQLdzQakMBCxYNl0YMkGsEKYy7MPLs0tHw167L1YqA75iHAJqdK9/stB35JoQrcCe69XjV6wTr1+gkURJIMipZHhy1eby6Rh7HpGQ+gkErCgelYO59vSHERYFK6/Sy55gg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i5e860cc8.versanet.de ([94.134.12.200] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sKMk6-0000XY-Qs; Thu, 20 Jun 2024 20:42:42 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sebastian Kropatsch Cc: linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] arm64: dts: rockchip: Improve LEDs on NanoPi R6C/R6S Date: Thu, 20 Jun 2024 20:42:42 +0200 Message-ID: <2564239.kdYZ1jHi8b@diego> In-Reply-To: <20240612205056.397204-4-seb-dev@mail.de> References: <20240612205056.397204-1-seb-dev@mail.de> <20240612205056.397204-4-seb-dev@mail.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Mittwoch, 12. Juni 2024, 22:48:12 CEST schrieb Sebastian Kropatsch: > Move led-3 node into NanoPi R6C/R6S's source files since they have > different functionalities on each board: On the R6S this LED is used > to signal LAN2 link up, while on the R6C this LED does not have a > pre-defined purpose. > > In addition to that: > - Remove deprecated label property > - Add color and function properties > - Add linux,default-trigger to trigger on Ethernet link Again, please don't group unrelated changes together into one patch. It makes things hard to read and hard to follow the changes. > > Signed-off-by: Sebastian Kropatsch > --- > > DT validation doesn't like the 'linux,default-trigger = "stmmac-0:01:link"' > properties, since "*:link" is not a valid value according to > [Documentation/devicetree/bindings/leds/common.yaml]. These LEDs do > have the specific purpose to show if an Ethernet link is up though. > There is one LED for each Ethernet port and they are labeled WAN and > LAN. > Using the 'linux,default-trigger' like this does work perfectly fine > with this solution. I could not find another way to achieve this. Please > let me know if there is a better way. > Maybe it would also be valid to add an entry to the DT bindings file to > allow "*:link" as a value for 'linux,default-trigger'? correct. If needed, things should be added to binding. Heiko